From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v11 0/3] Huawei laptops Date: Thu, 13 Dec 2018 09:31:22 +0100 Message-ID: References: <20181212230802.21140-1-ayman.bagabas@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20181212230802.21140-1-ayman.bagabas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ayman Bagabas Cc: alsa-devel@alsa-project.org, Hui Wang , Andy Shevchenko , Darren Hart , Jaroslav Kysela , Kailang Yang , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Thu, 13 Dec 2018 00:07:56 +0100, Ayman Bagabas wrote: > > This patch set is based on the new audio LED triggers in topic/leds-trigger branch from > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git > > Changes in v11: > * Minor code changes > > Changes in v10: > * Use ec_get_handle instead of acpi_get_handle since we are using the ec device > * Switch to WMI0_EXPENSIVE_GUID and wmi_query_block to fetch keycode when WMI0 is used > > Changes in v9: > * Explicitly use NULL in acpi_get_handle > * Drop __initconst from huawei_wmi_keymap > > Changes in v8: > * Switch to wmi_driver > * Use devm to allocate and manage devices > * Skip registering LED subsystem if a ACPI controller method was not found > > Changes in v7: > * Use audio LED triggers patch set > * Use KEY_CONFIG (XF86Tools) instead of KEY_PROG1. > In Windows, the key is used to launch Huawei PC manager. XF86Tools is > used by default on most desktop environments i.e. Gnome. > > Changes in v6: > * Review tags > > Changes in v5: > * Consistency in file names > * How module would be enabled (Kconfig) > * Match license in SPDX and MODULE_LICENSE > > Changes in v4: > * Code formatting > > Changes in v3: > * Support for Huawei MBX > * Style and formatting issues > > Ayman Bagabas (3): > ALSA: hda: fix front speakers on Huawei MBXP. > x86: add support for Huawei WMI hotkeys. > ALSA: hda: add support for Huawei WMI micmute LED Thank you for your patient works! Now I applied all three patches to topic/huawei-leds branch of sound git tree (with just minor corrections of patch descriptions). This is merged to for-next branch for 4.21 inclusion. Andy, feel free to merge topic/huawei-leds branch into your tree if needed. This one is already based on topic/leds-trigger branch, where both branches are immutable. thanks, Takashi