From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD3AC433EF for ; Fri, 21 Jan 2022 14:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381158AbiAUOoE (ORCPT ); Fri, 21 Jan 2022 09:44:04 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]:48752 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235452AbiAUOoE (ORCPT ); Fri, 21 Jan 2022 09:44:04 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A0E1E1F3AF; Fri, 21 Jan 2022 14:44:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1642776242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AdbKlDRug83o0KQNaUky39bFkRGjkGRzNFZeYdf1DRE=; b=tRIwMNDz3VDHmWB8Q8lxhBuYnzpcfWiSIw+ZnIG3G6TyikAqBZMnhSKL3XitKxltgBNfL4 yiJ8pIRoPb/zuzE4LmjBV4r6+4nrknu85Str3U2mb0cyQNT7LBPIbI4wIxZ849Yxffvmol LjDdCIyUDFzkAnYEqIwUdW7+qWIzxfM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1642776242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AdbKlDRug83o0KQNaUky39bFkRGjkGRzNFZeYdf1DRE=; b=ZDzg4gu5Hal1+1DoptQd99JQgTzLN6b8cI1jbVDnyWA5U3Tyr7W6H6LfWkMUSv5nr5zFvi zokGH7nRu9XYJoDQ== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 873E7A3B8B; Fri, 21 Jan 2022 14:44:02 +0000 (UTC) Date: Fri, 21 Jan 2022 15:44:02 +0100 Message-ID: From: Takashi Iwai To: Stefan Binding Cc: Mark Brown , "Rafael J . Wysocki" , Len Brown , Hans de Goede , Mark Gross , Jaroslav Kysela , Takashi Iwai , , , , , , , Lucas Tanure Subject: Re: [PATCH v5 8/9] ALSA: hda/realtek: Add support for HP Laptops In-Reply-To: <20220121143254.6432-9-sbinding@opensource.cirrus.com> References: <20220121143254.6432-1-sbinding@opensource.cirrus.com> <20220121143254.6432-9-sbinding@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Fri, 21 Jan 2022 15:32:53 +0100, Stefan Binding wrote: > > @@ -8926,7 +8953,21 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x103c, 0x8896, "HP EliteBook 855 G8 Notebook PC", ALC285_FIXUP_HP_MUTE_LED), > SND_PCI_QUIRK(0x103c, 0x8898, "HP EliteBook 845 G8 Notebook PC", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST), > SND_PCI_QUIRK(0x103c, 0x88d0, "HP Pavilion 15-eh1xxx (mainboard 88D0)", ALC287_FIXUP_HP_GPIO_LED), > - SND_PCI_QUIRK(0x103c, 0x89c3, "HP", ALC285_FIXUP_HP_GPIO_LED), > + SND_PCI_QUIRK(0x103c, 0x896E, "HP EliteBook x360 830 G9", ALC245_FIXUP_CS35L41_SPI_2), Please use lower letters for the hex number to align with others. (Also other lines you've added.) Though, it's no urgent problem, and we can fix it later if the whole patch set can be merged now. If v3 needs to be respinned, please apply the fix. With the correction to be done, Acked-by: Takashi Iwai thanks, Takashi