From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v5 3/3] ALSA: hda: add support for Huawei WMI micmute LED Date: Tue, 13 Nov 2018 18:32:30 +0100 Message-ID: References: <20181111190250.6055-1-ayman.bagabas@gmail.com> <20181111190250.6055-4-ayman.bagabas@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20181111190250.6055-4-ayman.bagabas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ayman Bagabas Cc: alsa-devel@alsa-project.org, Hui Wang , Andy Shevchenko , Darren Hart , Jaroslav Kysela , Kailang Yang , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Sun, 11 Nov 2018 20:02:45 +0100, Ayman Bagabas wrote: > > Some of Huawei laptops come with a LED in the micmute key. This patch > enables and disable this LED accordingly. disable what? > This enables micmute LED for: > 1. Matebook X (19e5:3200), (19e5:3201) > 2. Matebook X Pro (19e5:3204) > > Signed-off-by: Ayman Bagabas The code changes are mostly OK. Just a minor nitpicking: > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -5374,6 +5374,9 @@ static void alc_fixup_thinkpad_acpi(struct hda_codec *codec, > /* for alc295_fixup_hp_top_speakers */ > #include "hp_x360_helper.c" > > +/* for alc_fixup_huawei_micmute_led */ This should be alc_fixup_huawei_wmi */ With that fix, Reviewed-by: Takashi Iwai thanks, Takashi