From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: ThinkPad T480s & LED_MUTE, LED_MICMUTE Date: Thu, 21 Jun 2018 13:29:15 +0200 Message-ID: References: <20180615190959.pqipwnm6a3tf3lxc@pali> <20180616154309.ualrx2py6ndr5xgz@pali> <20180618102806.vwm4rhvxhn6hi43z@pali> <20180618112121.cl76a3oozsbbbqnb@pali> <20180619083712.dwb4d357sfxcgrre@pali> <20180621112407.fxwnkdvgtxwifryd@pali> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20180621112407.fxwnkdvgtxwifryd@pali> Sender: linux-kernel-owner@vger.kernel.org To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Thu, 21 Jun 2018 13:24:07 +0200, Pali Rohár wrote: > > On Tuesday 19 June 2018 10:42:12 Takashi Iwai wrote: > > On Tue, 19 Jun 2018 10:37:12 +0200, > > Pali Rohár wrote: > > > Interesting is this part: > > > > > > $ head /proc/asound/card0/codec#0 > > > Codec: Realtek ALC257 > > > Address: 0 > > > AFG Function Id: 0x1 (unsol 1) > > > Vendor Id: 0x10ec0257 > > > Subsystem Id: 0x17aa2258 > > > Revision Id: 0x100001 > > > No Modem Function Group found > > > Default PCM: > > > rates [0x560]: 44100 48000 96000 192000 > > > bits [0xe]: 16 20 24 > > > > > > It uses vendor id 0x10ec0257 and support for it was added into > > > snd-hda-codec-realtek in commit f429e7e494 which was introduced in > > > version v4.15. > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f429e7e494afaded76e62c6f98211a635aa03098 > > > > > > I applied this patch to Debian's 4.9 kernel and mute & mic mute leds > > > started working. This one patch was enough. > > > > > > Takashi, it is possible to backport this patch into -stable trees? > > > > It has already a Cc-to-stable, so it should have been backported. > > Maybe it wasn't applicable at that time due to lack of other dependent > > patches... > > > > In anyway, feel free to ping Greg for including it to 4.9.x if it > > works for you now. > > I sent email to Greg, but it was eaten by "email-bot of Greg > Kroah-Hartman's inbox". So I sent another patch email to stable ML. Better to put '[PATCH 4.9.y]' prefix in the subject to make clear that it's only for 4.9.y. Also, the line indicating the upstream commit id is: commit $ID upstream. Last but not least, if you resubmit the patch, you must give your own sign-off, too. thanks, Takashi