From: Richard Purdie <rpurdie@linux.intel.com>
To: Paul Eggleton <paul.eggleton@intel.com>
Cc: poky@pokylinux.org
Subject: Re: [PATCH 3/3] qemu: fix failure to find zlib header files during configure
Date: Mon, 22 Nov 2010 17:05:11 +0000 [thread overview]
Message-ID: <1290445511.1272.17129.camel@rex> (raw)
In-Reply-To: <e159ff2c957d06e1106b7ba221e7b36d3bc06fe9.1290423211.git.paul.eggleton@intel.com>
Hi Paul,
On Fri, 2010-11-19 at 12:37 +0000, Paul Eggleton wrote:
> Corrects problems during configure of qemu-native due to the BUILD_CFLAGS
> not being included when attempting to compile the test program for zlib
> within the configure script.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@intel.com>
> ---
> .../qemu/qemu-0.12.4/fix-configure-checks.patch | 16 ++++++++++++++++
> meta/recipes-devtools/qemu/qemu_0.12.4.bb | 3 ++-
> 2 files changed, 18 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-devtools/qemu/qemu-0.12.4/fix-configure-checks.patch
>
> diff --git a/meta/recipes-devtools/qemu/qemu-0.12.4/fix-configure-checks.patch b/meta/recipes-devtools/qemu/qemu-0.12.4/fix-configure-checks.patch
> new file mode 100644
> index 0000000..e397848
> --- /dev/null
> +++ b/meta/recipes-devtools/qemu/qemu-0.12.4/fix-configure-checks.patch
> @@ -0,0 +1,16 @@
> +Adds BUILD_CFLAGS to QEMU_CFLAGS so that zlib configure check succeeds.
> +Without this, zlib configure check was failing without zlib headers installed
> +on the host system.
> +
> +Author: Paul Eggleton <paul.eggleton@intel.com>
> +
> +--- qemu-0.12.4.orig/configure
> ++++ qemu-0.12.4/configure
> +@@ -99,6 +99,7 @@ QEMU_CFLAGS="-Wstrict-prototypes -Wredun
> + QEMU_CFLAGS="-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS"
> + QEMU_CFLAGS="-U_FORTIFY_SOURCE $QEMU_CFLAGS"
> + QEMU_CFLAGS="-I. -I\$(SRC_PATH) $QEMU_CFLAGS"
> ++QEMU_CFLAGS="$QEMU_CFLAGS $BUILD_CFLAGS"
> + LDFLAGS="-g $LDFLAGS"
> +
Should this be $CFLAGS? I just wonder what the effect of injecting
BUILD_CFLAGS would be in the target case (qemu vs. qemu-native)?
In the native case CFLAGS == BUILD_CFLAGS.
Cheers,
Richard
next prev parent reply other threads:[~2010-11-22 17:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 10:53 [PATCH 0/3] Patches for successful Fedora 14 build Paul Eggleton
2010-11-17 11:37 ` [PATCH 1/3] openssl: disable execstack flag to prevent problems with SELinux Paul Eggleton
2010-11-22 19:22 ` Richard Purdie
2010-11-23 11:00 ` Paul Eggleton
2010-11-18 11:34 ` [PATCH 2/3] sanity.bbclass: add wget to required utilities Paul Eggleton
2010-11-19 12:37 ` [PATCH 3/3] qemu: fix failure to find zlib header files during configure Paul Eggleton
2010-11-22 17:05 ` Richard Purdie [this message]
2010-11-22 17:18 ` Paul Eggleton
2010-11-28 14:41 ` Richard Purdie
2010-11-29 10:28 ` Paul Eggleton
2010-11-29 11:48 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290445511.1272.17129.camel@rex \
--to=rpurdie@linux.intel.com \
--cc=paul.eggleton@intel.com \
--cc=poky@pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox