From: Joshua Lock <josh@linux.intel.com>
To: Saul Wold <saul.wold@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/2] local.conf.sample: Note extra variables required when disabling en_US locale
Date: Fri, 03 Dec 2010 13:29:44 +0000 [thread overview]
Message-ID: <1291382984.2728.8.camel@scimitar> (raw)
In-Reply-To: <4CF7ED8F.6070203@intel.com>
On Thu, 2010-12-02 at 11:03 -0800, Saul Wold wrote:
> On 11/26/2010 06:23 AM, Joshua Lock wrote:
> > When changing which locales are generated for libc it may also be neccessary to
> > change IMAGE_LINGUAS and LIMIT_BUILT_LOCALES
> >
> > Signed-off-by: Joshua Lock<josh@linux.intel.com>
> > ---
> > meta/conf/local.conf.sample | 7 ++++++-
> > 1 files changed, 6 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
> > index fae949c..4ba250d 100644
> > --- a/meta/conf/local.conf.sample
> > +++ b/meta/conf/local.conf.sample
> > @@ -158,8 +158,13 @@ ENABLE_BINARY_LOCALE_GENERATION = "1"
> >
> > # Set GLIBC_GENERATE_LOCALES to the locales you wish to generate should you not
> > # wish to perform the time-consuming step of generating all LIBC locales.
> > +# NOTE: If removing en_US.UTF-8 you will also need to uncomment, and set
> > +# appropriate values for IMAGE_LINGUAS and LIMIT_BUILT_LOCALES
> > # WARNING: this may break localisation!
> > -#GLIBC_GENERATE_LOCALES = "en_GB.UTF-8 en_US.UTF-8"
> > +#GLIBC_GENERATE_LOCALES = "en_GB.UTF-8"
> > +# See message above as to whether setting these is required
> > +#IMAGE_LINGUAS ?= "en-gb"
> > +#LIMIT_BUILT_LOCALES ?= "POSIX en_GB"
> >
> Should these LOCALES be en_US, en_GB or BOTH? I know we have had
> discussion on this in the past.
>
> Let's be consistent on this please.
Good catch. I think the GLIBC_GENERATE_LOCALES should be both as it was
before but as the IMAGE_LINGUAS and LIMIT_BUILT_LOCALES only need
changing if en_US.UTF-8 is removed they should not include en_US
Updated patch follows and branch fixed:
From 6d532f464a897f28da4c7dcb72ddcad0bcc65f6c Mon Sep 17 00:00:00 2001
Message-Id:
<6d532f464a897f28da4c7dcb72ddcad0bcc65f6c.1291382830.git.josh@linux.intel.com>
In-Reply-To: <cover.1291382830.git.josh@linux.intel.com>
References: <cover.1291382830.git.josh@linux.intel.com>
From: Joshua Lock <josh@linux.intel.com>
Date: Fri, 26 Nov 2010 14:23:16 +0000
Subject: [PATCH 1/2] local.conf.sample: Note extra variables required
when disabling en_US locale
When changing which locales are generated for libc it may also be
neccessary to
change IMAGE_LINGUAS and LIMIT_BUILT_LOCALES
Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
meta/conf/local.conf.sample | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/meta/conf/local.conf.sample b/meta/conf/local.conf.sample
index fae949c..9bff292 100644
--- a/meta/conf/local.conf.sample
+++ b/meta/conf/local.conf.sample
@@ -158,8 +158,13 @@ ENABLE_BINARY_LOCALE_GENERATION = "1"
# Set GLIBC_GENERATE_LOCALES to the locales you wish to generate should
you not
# wish to perform the time-consuming step of generating all LIBC
locales.
+# NOTE: If removing en_US.UTF-8 you will also need to uncomment, and
set
+# appropriate values for IMAGE_LINGUAS and LIMIT_BUILT_LOCALES
# WARNING: this may break localisation!
#GLIBC_GENERATE_LOCALES = "en_GB.UTF-8 en_US.UTF-8"
+# See message above as to whether setting these is required
+#IMAGE_LINGUAS ?= "en-gb"
+#LIMIT_BUILT_LOCALES ?= "POSIX en_GB"
# Default to not build 32 bit libs on 64 bit systems, comment this
# out if that is desired
--
1.7.3.2
next prev parent reply other threads:[~2010-12-03 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 16:48 [PATCH 0/2] Two patches to help new users Joshua Lock
2010-11-26 14:23 ` [PATCH 1/2] local.conf.sample: Note extra variables required when disabling en_US locale Joshua Lock
2010-12-02 19:03 ` Saul Wold
2010-12-03 13:29 ` Joshua Lock [this message]
2010-11-26 16:43 ` [PATCH 2/2] sanity.bbclass: Warn people when TERMCMD is set to a non-installed program Joshua Lock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291382984.2728.8.camel@scimitar \
--to=josh@linux.intel.com \
--cc=poky@yoctoproject.org \
--cc=saul.wold@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox