Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	Chris Larson <clarson@kergoth.com>,
	"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: sstate status
Date: Tue, 07 Dec 2010 15:02:45 +0000	[thread overview]
Message-ID: <1291734165.1554.130.camel@rex> (raw)
In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1504D47543B26@shsmsx502.ccr.corp.intel.com>

On Tue, 2010-12-07 at 15:46 +0800, Tian, Kevin wrote: 
> >From: Richard Purdie [mailto:rpurdie@linux.intel.com]

> >http://git.pokylinux.org/cgit/cgit.cgi/poky-contrib/commit/?h=tk/sstate&id=0a4c46dc2c1
> >22ef5c1057380e79b75e302583b4a, siggen.py: fix python error when comparing sstate
> >generated from different srcpath
> >
> >I understand the need for this but I don't like the implementation :)
> >
> >We can't use OEROOT here as its not a standard variable and is
> >deprecated. I was initially thinking POKYBASE but that isn't right
> >either in bitbake. Hmm.
> 
> Could you elaborate why POKYBASE can't be used too? Because LAYERDIR is a
> one-time expansion action? If we're sure that POKYBASE is expanded before
> base signature generation, then it could work.

POKYBASE is poky specific and not a bitbake variable. Using it in
generic bitbake code is therefore a layer violation.

> >Chris, any suggestions? I'm actually struggling a bit to come up with a
> >variable that represents a "head" of the metadata :/. Perhaps filename
> >would be enough in this case?
> >
> >I'd also suggest we remove this path when we save the siginfo file, not
> >when we load it and do the comparison.
> 
> Yes, that's a better approach. I'll go that approach.

Thanks, I'll wait for an updated patch.

> That's my intention too. Above logic is to filter out native/cross dependencies.
> If we do that filter for native/cross tasks too, that means all dependencies 
> would be wiped out which is not what we want since they all fall into the
> match group. That's why I add the initial condition to restrict the filtering on
> on target packages. :-)

Ok, this makes sense. I merged it after adding in some comments to the
code.

I've asked Paul to pull together a branch with all the changes in for
sstate and see how we stand.


Cheers,

Richard





  reply	other threads:[~2010-12-07 15:03 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-03 16:34 sstate status Paul Eggleton
2010-12-03 22:11 ` Richard Purdie
2010-12-05 11:10   ` Tian, Kevin
2010-12-06  1:29     ` Richard Purdie
2010-12-07  7:46       ` Tian, Kevin
2010-12-07 15:02         ` Richard Purdie [this message]
2010-12-08  0:40           ` Tian, Kevin
2010-12-06 16:06   ` Paul Eggleton
2010-12-07 12:46     ` Richard Purdie
2010-12-07 16:36       ` Paul Eggleton
2010-12-08 11:22         ` Tian, Kevin
2010-12-08 11:31           ` Paul Eggleton
2010-12-08 11:41             ` Tian, Kevin
2010-12-03 23:31 ` Gary Thomas
2010-12-04 12:47   ` Gary Thomas
2010-12-05 11:19     ` Tian, Kevin
2010-12-05 12:02       ` Gary Thomas
2010-12-06 11:19         ` Gary Thomas
     [not found]         ` <4CFCC607.9040803@mlbassoc.com>
2010-12-07  7:17           ` Tian, Kevin
2010-12-05 11:07 ` Tian, Kevin
  -- strict thread matches above, loose matches on Subject: below --
2010-12-08 14:02 Paul Eggleton
2010-12-08 14:06 ` Paul Eggleton
2010-12-08 14:15   ` Tian, Kevin
2010-12-08 14:50     ` Paul Eggleton
2010-12-08 14:52       ` Tian, Kevin
2010-12-08 14:41   ` Gary Thomas
2010-12-08 15:31     ` Gary Thomas
2010-12-08 15:55     ` Paul Eggleton
2010-12-08 17:14       ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291734165.1554.130.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=clarson@kergoth.com \
    --cc=kevin.tian@intel.com \
    --cc=paul.eggleton@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox