From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tim.rpsys.net (93-97-173-237.zone5.bethere.co.uk [93.97.173.237]) by mx1.pokylinux.org (Postfix) with ESMTP id CC9094C81021 for ; Thu, 9 Dec 2010 06:46:20 -0600 (CST) Received: from localhost (localhost [127.0.0.1]) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id oB9CkI2w006771; Thu, 9 Dec 2010 12:46:18 GMT Received: from tim.rpsys.net ([127.0.0.1]) by localhost (tim.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 06269-09; Thu, 9 Dec 2010 12:46:14 +0000 (GMT) Received: from [192.168.3.10] ([192.168.3.10]) (authenticated bits=0) by tim.rpsys.net (8.13.6/8.13.8) with ESMTP id oB9CkAQY006765 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Dec 2010 12:46:10 GMT From: Richard Purdie To: "Xu, Dongxiao" In-Reply-To: References: <1291804222.1554.256.camel@rex> <625BA99ED14B2D499DC4E29D8138F1504D515D0DC5@shsmsx502.ccr.corp.intel.com> <1291819067.1554.606.camel@rex> <625BA99ED14B2D499DC4E29D8138F1504D515D10E7@shsmsx502.ccr.corp.intel.com> <1291893846.1554.793.camel@rex> Date: Thu, 09 Dec 2010 12:45:58 +0000 Message-ID: <1291898758.1554.819.camel@rex> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 X-Virus-Scanned: amavisd-new at rpsys.net Cc: Chris Larson , "poky@yoctoproject.org" Subject: Re: About the operator "??=" X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Dec 2010 12:46:21 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Thu, 2010-12-09 at 20:13 +0800, Xu, Dongxiao wrote: > w/ patch: > time bitbake -p > > real 0m26.189s > user 0m25.480s > sys 0m0.420s > > w/o patch: > time bitbake -p > > real 0m30.940s > user 0m30.230s > sys 0m0.460s Thanks, thats 5/31 so about 15% which is nice and a confirmed speedup. Sometimes the profiling can distort things slightly so this is a good sanity check. Can you see what the impact is to parsing if we do all the work we do in setVar in setVarFlag too? I'm definitely in favour of the patch, just a few details to make sure of :) Cheers, Richard