Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@linux.intel.com>
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 0/1][RFC] Optimize file parsing speed
Date: Thu, 09 Dec 2010 14:40:14 +0000	[thread overview]
Message-ID: <1291905614.1554.868.camel@rex> (raw)
In-Reply-To: <D5AB6E638E5A3E4B8F4406B113A5A19A314F2A72@shsmsx501.ccr.corp.intel.com>

On Wed, 2010-12-08 at 14:53 +0800, Xu, Dongxiao wrote:
> Xu, Dongxiao wrote:
> > Richard Purdie wrote:
> >> On Mon, 2010-11-29 at 13:45 +0800, Xu, Dongxiao wrote:
> >>> Richard Purdie wrote:
> > Like the whole d.keys(), exported variables are also different among
> > recipes, since recipe may export or unset certain variables for
> > itself. So to implement this, we need to keep a common list, and then
> > handle recipe specific export/unset variables.  
> > 
> > Does my understanding correct?
> 
> Here I mean even the exported variables may be different among
> different recipes, since each recipe may export or unset certain
> variables for itself. So is it possible for us to keep a common
> exported variable list?

The reason these functions are slow is that our dictionary is huge and
d.keys() takes time to construct and then iterate over.

Instead, if we make a cache in setVarFlag of anything with an export
flag set, we then have a pregenerated list.

Yes, the list is different between recipes but that doesn't mean we
can't prebuild the list when parsing.

Cheers,

Richard



      reply	other threads:[~2010-12-09 14:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22  6:04 [PATCH 0/1][RFC] Optimize file parsing speed Dongxiao Xu
2010-11-22  6:02 ` [PATCH 1/1] utility-tasks.bbclass: Move distro related tasks to distrodata.bbclass Dongxiao Xu
2010-11-28 14:27 ` [PATCH 0/1][RFC] Optimize file parsing speed Richard Purdie
2010-11-29  0:32   ` Tian, Kevin
2010-11-29  5:45   ` Xu, Dongxiao
2010-11-29 12:41     ` Richard Purdie
2010-12-01  1:48       ` Xu, Dongxiao
2010-12-08  6:53       ` Xu, Dongxiao
2010-12-09 14:40         ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291905614.1554.868.camel@rex \
    --to=rpurdie@linux.intel.com \
    --cc=dongxiao.xu@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox