Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lu Jingdong <jingdong.lu@windriver.com>
Cc: poky <poky@yoctoproject.org>
Subject: Re: [PATCH 9/9] ed: Change bin path
Date: Wed, 15 Dec 2010 09:12:29 +0000	[thread overview]
Message-ID: <1292404349.26558.1587.camel@rex> (raw)
In-Reply-To: <1292317109.2240.1.camel@eric-desktop>

On Tue, 2010-12-14 at 16:58 +0800, Lu Jingdong wrote:
> Subject: [PATCH 9/9] ed: Change bin path
> 
> Change bin path of ed from usr/bin into bin for LSB.
> 
> Signed-off-by: Jingdong Lu <jingdong.lu@windriver.com>
> ---
>  meta/recipes-extended/ed/ed_1.5.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-extended/ed/ed_1.5.bb
> b/meta/recipes-extended/ed/ed_1.5.bb
> index 2242ffa..a609f42 100644
> --- a/meta/recipes-extended/ed/ed_1.5.bb
> +++ b/meta/recipes-extended/ed/ed_1.5.bb
> @@ -8,7 +8,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=f27defe1e96c2e1ecd4e0c9be8967949 \
> 
> file://main.c;endline=24;md5=177fe82d0649e545591a13fdce5733e8"
> 
>  SECTION = "base"
> -PR = "r0"
> +PR = "r1"
> 
>  SRC_URI = "${GNU_MIRROR}/ed/ed-${PV}.tar.gz \
>             file://ed-1.2-build.patch"
> @@ -18,5 +18,5 @@ do_configure() {
>  }
> 
>  do_install() {
> -       oe_runmake 'DESTDIR=${D}' install
> +       oe_runmake 'DESTDIR=${D}' bindir=/bin install
>  }

This at the very least needs a strong comment about why we're doing
this.

I'd suggest adding something like to the recipe instead:

# LSB states that ed should be in /bin/
bindir = "${base_bindir}"

Cheers,

Richard




      reply	other threads:[~2010-12-15  9:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-14  8:58 [PATCH 9/9] ed: Change bin path Lu Jingdong
2010-12-15  9:12 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292404349.26558.1587.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jingdong.lu@windriver.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox