Poky Project Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <josh@openedhand.com>
To: poky@yoctoproject.org
Subject: Re: mpd: COMMERCIAL_LICENSE etc
Date: Mon, 20 Dec 2010 11:34:35 +0000	[thread overview]
Message-ID: <1292844875.2466.11.camel@scimitar> (raw)
In-Reply-To: <AANLkTi=MRFdxg-0VO-shfgGf80607Fe9RhT1VtPMRwsF@mail.gmail.com>

On Sat, 2010-12-18 at 18:26 +0100, Frans Meulenbroeks wrote:
> Hi,
> 
> I was trying to add mpd to poky and bumped upon COMMERCIAL_LICENSE
> Should I set
> COMMERCIAL_LICENSE = ""
> in my local.conf. That allows me to add lame etc to mpd.
> Not sure if that is the desired way. Overruling COMMERCIAL_LICENSE seems wrong.

This is something we need to document better, and I filed a bug about
that recently (#576).

There's a comment in poky.conf on how the variable is used
(http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/conf/distro/poky.conf#n130) as well as a comment on the bug I filed (http://bugzilla.pokylinux.org/show_bug.cgi?id=576#c1)

> 
> I'm also stuct at how to add these conditionally.
> The OE recipe has:
>            ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'libmad
> libid3tag lame', d)}"
> I tried replacing ENTERPRISE_DISTRO with COMMERCIAL_LICENSE but that
> did not work as it is not a boolean var
> and my python is not good enough to come up with a better fix.

I think adding a boolean value for detecting whether we can build this
software would be a great idea, care to file a bug?

Cheers,
Joshua
-- 
Joshua Lock
        Intel Open Source Technology Centre



      reply	other threads:[~2010-12-20 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 17:26 mpd: COMMERCIAL_LICENSE etc Frans Meulenbroeks
2010-12-20 11:34 ` Joshua Lock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292844875.2466.11.camel@scimitar \
    --to=josh@openedhand.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox