Poky Project Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] send-pull-request: Use current date in mail headers
Date: Tue, 21 Dec 2010 10:52:48 +0000	[thread overview]
Message-ID: <1292928768.2701.1.camel@scimitar> (raw)
In-Reply-To: <839e299af32e8de5c86e7225954533a452409a2d.1292870880.git.dvhart@linux.intel.com>

On Mon, 2010-12-20 at 10:50 -0800, Darren Hart wrote:
> Some users experience problems viewing the pull requests as a sequential
> mail series due to the script using the git commit date for the patches
> and today's date for the cover letter.
> 
> Address this by renaming the email Date: header to Old-Date: and adding
> a new Date: header with a current timestamp.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Reported-by: Gary Thomas <gary@mlbassoc.com>
> Cc: Josh Lock <josh@linux.intel.com>

Acked-by: Joshua Lock <josh@linux.intel.com>

> ---
>  scripts/send-pull-request |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index 0576a5d..03a78f9 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -118,7 +118,11 @@ if [ "$cont" == "y" ] || [ "$cont" == "Y" ]; then
>          # 
>          # Use tail to remove the email envelope from git or formail as
>          # msmtp (sendmail) would choke on them.
> -        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" | tail -n +2 | sendmail -t
> +        #
> +        # Modify the patch date for sequential delivery, but retain the
> +        # original date as "Old-Date".
> +        DATE=$(date +"%a, %d %b %Y %k:%M:%S %z")
> +        cat $PATCH | formail -I "To: $TO" -I "CC: $CC" -i "Date: $DATE" | tail -n +2 | sendmail -t
>          if [ $? -eq 1 ]; then
>              ERROR=1
>          fi

-- 
Joshua Lock
        Intel Open Source Technology Centre



  reply	other threads:[~2010-12-21 10:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-20 18:50 [PATCH 0/1] send-pull-request: Use current date in mail headers Darren Hart
2010-12-20 18:50 ` [PATCH 1/1] " Darren Hart
2010-12-21 10:52   ` Joshua Lock [this message]
2010-12-20 19:33 ` [PATCH 0/1] " Gary Thomas
2010-12-21 20:59 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292928768.2701.1.camel@scimitar \
    --to=josh@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox