Poky Project Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <josh@openedhand.com>
To: poky@yoctoproject.org
Subject: Re: [PATCH 0/1] SRC_URI checksum support v3
Date: Tue, 21 Dec 2010 10:54:23 +0000	[thread overview]
Message-ID: <1292928863.2701.2.camel@scimitar> (raw)
In-Reply-To: <20101221053230.GB20780@kyu3-hedt>

On Tue, 2010-12-21 at 13:32 +0800, Yu Ke wrote:
> On Dec 20, 16:10, Richard Purdie wrote:
> > On Fri, 2010-12-17 at 14:33 +0800, Yu Ke wrote:
> > > This patch add SRC_URI checksum support. With this patch,fetcher
> > > can verify the MD5 and SHA256 checksum of download src with the
> > > value defined in recipes SRC_URI.
> > > 
> > > This is the v3 patch with following changes compared with v2:
> > > - add configurable variable BB_STRICT_CHECKSUM to handle checksum missing case
> > >   if checksum is missing and BB_STRICT_CHECKSUM = "1", bitbake will fatal
> > > - add check to only verify checksum for protocol http/https/ftp/ftps, not
> > >   verify checksum for local file and other SCM
> > > 
> > > Pull URL: git://git.pokylinux.org/poky-contrib.git
> > >   Branch: kyu3/srcuri-v3
> > >   Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kyu3/srcuri-v3
> > 
> > I merged this, then realised there was a problem with subsequent builds
> > proceeding with corrupt files. I've pushed a fix for at least part of
> > that.
> 
> Thanks, it is indeed necessary fix.
> 
> BTW, I am also thinking if we could merge Fetch.write_md5sum and
> Fetch.verify_md5sum into verify_checksum, since they are all checksum
> related, puting them together would be more clean logically.

That makes the assumption that you only want to verify a checksum when
fetching one, which I don't think is correct?

Cheers,
Joshua
-- 
Joshua Lock
        Intel Open Source Technology Centre



  reply	other threads:[~2010-12-21 10:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17  6:33 [PATCH 0/1] SRC_URI checksum support v3 Yu Ke
2010-12-17  5:52 ` [PATCH 1/1] FetchData: add SRC_URI checksum Yu Ke
2010-12-20 16:10 ` [PATCH 0/1] SRC_URI checksum support v3 Richard Purdie
2010-12-21  5:32   ` Yu Ke
2010-12-21 10:54     ` Joshua Lock [this message]
2010-12-21 11:04       ` Richard Purdie
2010-12-21 13:17       ` Yu Ke
2010-12-21 13:25         ` Yu Ke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292928863.2701.2.camel@scimitar \
    --to=josh@openedhand.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox