Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Wolfgang Denk <wd@denx.de>
Cc: Adrian Alonso <aalonso@secretlab.ca>,
	"poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 05/25] u-boot: disable -Os option not supported by gcc
Date: Thu, 20 Jan 2011 23:24:14 +0000	[thread overview]
Message-ID: <1295565854.14388.27977.camel@rex> (raw)
In-Reply-To: <20110120230537.5CF85D301D7@gemini.denx.de>

On Fri, 2011-01-21 at 00:05 +0100, Wolfgang Denk wrote:
> Dear Darren Hart,
> 
> In message <4D3884A0.8030602@linux.intel.com> you wrote:
> >
> > I ran into this in the recent u-boot_git.bb recipe I added. Rather than 
> > create a patch to the Makefile, I found it simpler to adding OPTFLAGS to 
> > the EXTRA_OEMAKE variable in the recipe:
> > 
> > EXTRA_OEMAKE = "CROSS_COMPILE=${TARGET_PREFIX} OPTFLAGS=''"
> > 
> > This negates the -Os in the Makefile.
> 
> What exactly is the reason that -Os is not supported?

Its not so much not supported, its that gcc 4.5 seems to have totally
broken it and for better or worse, we're on that gcc version. Until we
have a toolchain where the option works what do we do?

> Note that -Os makes is intentional in U-Boot, and omitting it may
> cause problems on a number of systems.
> 
> -O2 will create significantly larger code which does not fit into
> flash sectors on some systems; on other systems, the code will not
> fit any more in the size limitations given by the NAND loader.
> 
> In other works, -O2 breaks a number of systems.
> 
> I discourage doing this.

Well, its a case of "totally broken" or a risk of size issues on some
systems so I'm in favour of the latter. I agree the toolchain issues
need to be resolved and I'm sure they will sooner or later. I have
noticed upstream gcc don't seem to like the -Os option though and it
often seems to be the source of problems...

Cheers,

Richard



  reply	other threads:[~2011-01-20 23:24 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17 20:29 [PATCH 01/25] xilinx-kernel: bbclass to handle linux kernel hw/sw integration Adrian Alonso
2011-01-17 20:29 ` [PATCH 02/25] xilinx-boot: bbclass to handle u-boot " Adrian Alonso
2011-01-17 20:29 ` [PATCH 03/25] gcc: crosssdk unset TARGET_FPU Adrian Alonso
2011-01-17 23:55   ` Ilya Yanok
2011-01-18  0:59     ` Adrian Alonso
2011-01-18  1:45       ` Ilya Yanok
2011-01-20  2:11       ` Ilya Yanok
2011-01-20 17:35         ` Saul Wold
2011-01-20 17:53           ` Adrian Alonso
2011-01-21  0:43             ` Ilya Yanok
2011-01-21  0:47           ` [PATCH] native,nativesdk,crosssdk: reset TARGET_FPU Ilya Yanok
2011-01-17 20:29 ` [PATCH 04/25] u-boot: update version use xilinx-boot bbclass Adrian Alonso
2011-01-17 20:29 ` [PATCH 05/25] u-boot: disable -Os option not supported by gcc Adrian Alonso
2011-01-20 18:53   ` Darren Hart
2011-01-20 18:55     ` Darren Hart
2011-01-20 21:41       ` Adrian Alonso
2011-01-20 23:05     ` Wolfgang Denk
2011-01-20 23:24       ` Richard Purdie [this message]
2011-01-22 14:48         ` Wolfgang Denk
2011-01-23  0:11           ` Richard Purdie
2011-01-25  9:09             ` Wolfgang Denk
2011-01-25 22:49               ` Richard Purdie
2011-01-17 20:29 ` [PATCH 06/25] virtex4: fix machine name in u-boot preferred version Adrian Alonso
2011-01-17 20:29 ` [PATCH 07/25] virtex5: " Adrian Alonso
2011-01-17 20:29 ` [PATCH 08/25] xilinx-boot: add ml405 in default target configuration Adrian Alonso
2011-01-17 20:29 ` [PATCH 09/25] u-boot-xilinx: ml405 uartlite support Adrian Alonso
2011-01-17 20:29 ` [PATCH 10/25] xilinx-boot: split configure function Adrian Alonso
2011-01-17 20:29 ` [PATCH 11/25] xilinx-boot: add do_mk_xparam function Adrian Alonso
2011-01-17 20:29 ` [PATCH 12/25] u-boot-xilinx: ml507 uartlite support Adrian Alonso
2011-01-17 20:29 ` [PATCH 13/25] u-boot-xilinx: remove hardcoded include path Adrian Alonso
2011-01-17 20:29 ` [PATCH 14/25] linux-xilinx: update kernel version 2.6.37 rc4 Adrian Alonso
2011-01-17 20:29 ` [PATCH 15/25] linux-xilinx: remove hardcoded include path Adrian Alonso
2011-01-17 20:29 ` [PATCH 16/25] linux-xilinx: add license files checksum Adrian Alonso
2011-01-17 20:29 ` [PATCH 17/25] device-table: add tty uartlite static dev nodes Adrian Alonso
2011-01-17 20:29 ` [PATCH 18/25] u-boot-xilinx: add license files checksum Adrian Alonso
2011-01-17 20:29 ` [PATCH 19/25] tune-ppc405: append ppc440 in PACKAGE_EXTRA_ARCHS Adrian Alonso
2011-01-17 20:29 ` [PATCH 20/25] tune-ppc440: append ppc405 " Adrian Alonso
2011-01-17 20:29 ` [PATCH 21/25] virtex4: update default serial console Adrian Alonso
2011-01-17 20:29 ` [PATCH 22/25] virtex5: " Adrian Alonso
2011-01-17 20:29 ` [PATCH 23/25] defconfig: virtex4 config for linux 2.6.37.rc4 Adrian Alonso
2011-01-17 20:29 ` [PATCH 24/25] defconfig: virtex5 " Adrian Alonso
2011-01-17 20:29 ` [PATCH 25/25] openssl: powerpc gnueabi toolchain support Adrian Alonso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295565854.14388.27977.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=aalonso@secretlab.ca \
    --cc=poky@yoctoproject.org \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox