Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lianhao Lu <lianhao.lu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/3] [Bug#728] corrected environment files content
Date: Wed, 16 Feb 2011 17:05:58 +0000	[thread overview]
Message-ID: <1297875958.11289.290.camel@rex> (raw)
In-Reply-To: <cover.1297848716.git.lianhao.lu@intel.com>

On Wed, 2011-02-16 at 17:35 +0800, Lianhao Lu wrote:
> From: Lianhao Lu <lianhao.lu@intel.com>
> 
> 1. Added libtool sysroot related param value into environment files.
> 2. Moved common code between meta-environment.bb and populate_sdk.bbclass into toolchain-script.bbclass.
> 3. Set CONFIG_SITE to pkgconfig site files for meta-toolchain.bb.
> 
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>   Branch: llu/bug728
>   Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/bug728
> 
> Thanks,
>     Lianhao Lu <lianhao.lu@intel.com>

Hi Lianhao,

It looks like part of the first patch should really be in the second
patch?

I also don't understand the third change, how are CONFIG_SITE and
pkgconfig connected?

Cheers,

Richard



  parent reply	other threads:[~2011-02-16 17:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-16  9:35 [PATCH 0/3] [Bug#728] corrected environment files content Lianhao Lu
2011-02-16  9:35 ` [PATCH 1/3] toolchain-scripts.bbclass: Added libtool sysroot support Lianhao Lu
2011-02-16  9:35 ` [PATCH 2/3] meta-environment/populate_sdk: moving common code to toolchain-script Lianhao Lu
2011-02-16  9:35 ` [PATCH 3/3] meta-toolchain.bb: Set value for CONFIG_SITE Lianhao Lu
2011-02-16 17:05 ` Richard Purdie [this message]
2011-02-17  3:12   ` [PATCH 0/3] [Bug#728] corrected environment files content Lu, Lianhao
  -- strict thread matches above, loose matches on Subject: below --
2011-02-17  3:08 [PATCH 0/3] [Bug #728] " Lianhao Lu
2011-02-22 15:53 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297875958.11289.290.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=lianhao.lu@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox