Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Lianhao Lu <lianhao.lu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/1] Fixing do_rootfs_ipk failure
Date: Tue, 15 Mar 2011 21:15:56 +0000	[thread overview]
Message-ID: <1300223756.30423.1842.camel@rex> (raw)
In-Reply-To: <cover.1300176847.git.lianhao.lu@intel.com>

On Tue, 2011-03-15 at 16:15 +0800, Lianhao Lu wrote:
> From: Lianhao Lu <lianhao.lu@intel.com>
> 
> This patch fixes Bug #870. It removes the duplicated values in PACKAGE_ARCHS which would results an error in opkg-cl.
> 
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>   Branch: llu/bug870
>   Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/bug870
> 
> Thanks,
>     Lianhao Lu <lianhao.lu@intel.com>
> ---
> 
> 
> Lianhao Lu (1):
>   package_ipk.bbclass: Remove the duplication in PACKAGE_ARCHS.
> 
>  meta/classes/package_ipk.bbclass |   16 ++++++++++++++--
>  1 files changed, 14 insertions(+), 2 deletions(-)

Whilst this patch is good, it papers over the underlying problem as that
variable should never have duplicates in it. For that reason I don't
want to merge it but fix that issue instead. There are two things we
should do here:

a) Merge a fix to remove the duplication (I've done this with a quick
hacky workaround and proposed a better one on the OE Core list as it
needs discussion)
b) Add a sanity test for the PACKAGE_ARCHS variable to detect this
problem in the future.

Cheers,

Richard



      parent reply	other threads:[~2011-03-15 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-15  8:15 [PATCH 0/1] Fixing do_rootfs_ipk failure Lianhao Lu
2011-03-15  8:15 ` [PATCH 1/1] package_ipk.bbclass: Remove the duplication in PACKAGE_ARCHS Lianhao Lu
2011-03-15 21:15 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300223756.30423.1842.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=lianhao.lu@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox