Poky Project Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Kang Kai <Kai.Kang@windriver.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] msmtp: add link sendmail for lsb command check
Date: Fri, 18 Mar 2011 09:56:27 +0000	[thread overview]
Message-ID: <1300442187.30423.2191.camel@rex> (raw)
In-Reply-To: <4D831F31.3000004@windriver.com>

On Fri, 2011-03-18 at 17:00 +0800, Kang Kai wrote:
> From: Kang Kai <kai.kang@windriver.com>
> 
> LSB command check will test the exist of sendmail, so make sendmail
> link to msmtp in order to pass the test.
> 
> Related to [YOCTO #520]
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>
> ---
>   meta/recipes-extended/msmtp/msmtp_1.4.23.bb |   10 +++++++++-
>   1 files changed, 9 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb 
> b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> index cb3d83c..b3500d0 100644
> --- a/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> +++ b/meta/recipes-extended/msmtp/msmtp_1.4.23.bb
> @@ -6,7 +6,7 @@ SECTION = "console/network"
>   PRIORITY = "required"
>   LICENSE = "GPLv3"
>   DEPENDS = "zlib gnutls"
> -PR = "r0"
> +PR = "r1"
> 
> 
>   #COPYING or Licence
> @@ -19,3 +19,11 @@ SRC_URI[md5sum] = "5fb7ae88186624cdb125d3efad3fdc16"
>   SRC_URI[sha256sum] = 
> "269cd30eeb867167c6a599e23399f4fc24196fcdef3bac5b120d806b3b421810"
> 
>   inherit gettext autotools
> +
> +pkg_postinst_${PN} () {
> +    update-alternatives --install ${sbindir}/sendmail sendmail 
> ${bindir}/msmtp 100
> +}
> +
> +pkg_prerm_${PN} () {
> +    update-alternatives --remove sendmail ${bindir}/msmtp
> +}

Instead of doing this directly could you use the update-alternatives
class please? meta/recipes-connectivity/iproute2/iproute2.inc shows an
example of this. I think it should be something like:

inherit update-alternatives

ALTERNATIVE_NAME = "sendmail"
ALTERNATIVE_PATH = "${sbindir}/mstmp"
ALTERNATIVE_LINK = "${sbindir}/sendmail"
ALTERNATIVE_PRIORITY = "100"

Thanks,

Richard





  reply	other threads:[~2011-03-18  9:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18  1:34 [PATCH 0/1] msmtp: add link sendmail to pass LSB test Kang Kai
2011-03-18  1:34 ` [PATCH 1/1] msmtp: add link sendmail for lsb command check Kang Kai
2011-03-18  1:44   ` Richard Purdie
2011-03-18  9:00     ` Kang Kai
2011-03-18  9:00     ` Kang Kai
2011-03-18  9:56       ` Richard Purdie [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-03-21  2:59 [PATCH 0/1] msmtp: add link sendmail to pass LSB test Kang Kai
2011-03-21  2:59 ` [PATCH 1/1] msmtp: add link sendmail for lsb command check Kang Kai
2011-03-21  3:40   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300442187.30423.2191.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Kai.Kang@windriver.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox