Poky Project Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: poky@yoctoproject.org
Subject: Re: RFC: design of network based PR service
Date: Thu, 28 Apr 2011 14:04:32 -0700	[thread overview]
Message-ID: <1304024672.2171.396.camel@vorpal> (raw)
In-Reply-To: <4DB9859D.7070609@windriver.com>

On Thu, 2011-04-28 at 10:19 -0500, Mark Hatle wrote:
> On 4/28/11 4:22 AM, Martin Jansa wrote:
> > On Thu, Apr 28, 2011 at 03:08:03PM +0800, Lu, Lianhao wrote:
> >> Hi Guys,
> >>
> >> Here is the design of network based PR service, please help to review and 
> >> give you comment. Thanks a lot!
> > 
> > Hi,
> > 
> > looks good, just wondering if we can use the same mechanism for
> > LOCALCOUNT numbers in SRCPV, we can even use same table if we prefix
> > first column ie LOCALCOUNT_${PN} and CheckSum in 2nd column would be
> > actuall git hash (from SRCREV or HEAD for AUTOREV) or 2nd table with
> > similar structure.
> > 
> > But it wont work very well if one builder is using AUTOREV and another
> > one isn't, but that can be resolved by allowing only trusted builders
> > with same configuration (wrt AUTOREV) to send such tuples.
> > 
> > Do we have at least 2 groups of "users".
> > 1) trusted which increments PR when hash is not found
> > 2) public which can query PR for given hash (not sure what they should
> >    do if hash is not found)
> 
> I think this points our something necessary.  There are manual indications of a
> change.  I.e. the current "PR" usage.  If I change the recipe, patches, etc I
> should expect to update the 'PR' to the next value.  However, if something ELSE
> changes (affecting the checksum), or an end user forgets to change the PR, the
> auto increment should be used.

Why would you need to update the PR manually? Detecting changes in the
recipe/patches/etc should all be handled by the checksumming.

Cheers,
Joshua
-- 
Joshua Lock
        Yocto Build System Monkey
        Intel Open Source Technology Center



  reply	other threads:[~2011-04-28 21:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28  7:08 RFC: design of network based PR service Lu, Lianhao
2011-04-28  7:15 ` Koen Kooi
2011-04-28  9:22 ` Martin Jansa
2011-04-28 15:19   ` Mark Hatle
2011-04-28 21:04     ` Joshua Lock [this message]
2011-04-28 21:23       ` Mark Hatle
2011-04-28 22:02         ` [OE-core] " Chris Larson
2011-04-28 22:08           ` Mark Hatle
2011-04-29  5:28         ` Lu, Lianhao
2011-04-29 12:44           ` Mark Hatle
2011-05-02 22:40           ` Khem Raj
2011-04-29  3:10 ` Zhang, Jessica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304024672.2171.396.camel@vorpal \
    --to=josh@linux.intel.com \
    --cc=mark.hatle@windriver.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox