Poky Project Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 05/12] qt4-tools-native: update from OpenEmbedded
Date: Thu, 3 Feb 2011 02:58:58 +0000	[thread overview]
Message-ID: <201102030258.59288.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <1296582252.13501.20225.camel@rex>

On Tuesday 01 February 2011 17:44:12 you wrote:
> Please don't reindent files when making other changes, it makes it hard
> to see where the real changes were. I've pulled things but taken out the
> worst whitespace changes manually this time.

A lot of those changes were brought in from meta-oe, although I admit I added 
a fair few others. I will endeavour to keep indentation changes (if any) 
separate in future.
 
> Please keep in mind:
> 
> shell functions/code use tabs
> python code uses four space indentation

Is there a particular reason for this? Can we not use four spaces everywhere? 
I see a wiki document that spells this out [1] however if it's of any 
consequence, OE's documentation specifies spaces only [2].

Cheers,
Paul

[1] 
https://wiki.pokylinux.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating#White_Space_Management

[2] http://docs.openembedded.org/usermanual/html/recipes_syntax.html


  parent reply	other threads:[~2011-02-03  2:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-29  2:29 [PATCH 00/12] Qt4 updates v3 Paul Eggleton
2011-01-29  2:30 ` [PATCH 01/12] Add directfb 1.4.6 from meta-openembedded Paul Eggleton
2011-01-29  2:30 ` [PATCH 02/12] qt4: Bring in improvements " Paul Eggleton
2011-01-29  2:30 ` [PATCH 03/12] qt4: add qt4-embedded 4.6.3 " Paul Eggleton
2011-01-29  2:30 ` [PATCH 04/12] qt4: add 4.7.1 version " Paul Eggleton
2011-01-29  2:30 ` [PATCH 05/12] qt4-tools-native: update from OpenEmbedded Paul Eggleton
2011-02-01 17:44   ` Richard Purdie
2011-02-01 18:02     ` Koen Kooi
2011-02-03  2:58     ` Paul Eggleton [this message]
2011-02-03  9:13       ` Richard Purdie
2011-01-29  2:30 ` [PATCH 06/12] glib-2.0: extend to nativesdk Paul Eggleton
2011-01-29  2:30 ` [PATCH 07/12] dbus: " Paul Eggleton
2011-01-29  2:30 ` [PATCH 08/12] qt4: Add qt4-tools-nativesdk based on qt4-tools-sdk from OpenEmbedded Paul Eggleton
2011-01-29  2:30 ` [PATCH 09/12] package.bbclass: add nodeprrecs flag to RRECOMMENDS_pkgname Paul Eggleton
2011-01-29  2:30 ` [PATCH 10/12] avahi: prevent unnecessary runtime dependency on gtk+ Paul Eggleton
2011-01-29  2:30 ` [PATCH 11/12] qt4: Add meta-toolchain-qte and dependent tasks from OpenEmbedded Paul Eggleton
2011-02-01 17:44   ` Richard Purdie
2011-02-03  2:48     ` Paul Eggleton
2011-01-29  2:30 ` [PATCH 12/12] qt4: set RRECOMMENDS correctly for qt4 demos and examples packages Paul Eggleton
2011-01-31 14:08 ` [PATCH 00/12] Qt4 updates v3 Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102030258.59288.paul.eggleton@linux.intel.com \
    --to=paul.eggleton@linux.intel.com \
    --cc=poky@yoctoproject.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox