From: Gary Thomas <gary@mlbassoc.com>
To: Poky <poky@lists.pokylinux.org>
Subject: Inconsistent timestamp use
Date: Wed, 03 Nov 2010 07:58:38 -0600 [thread overview]
Message-ID: <4CD16A8E.7090100@mlbassoc.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
The Poky root file system (init scripts) has a mechanism for
supporting systems without a working hardware [time of day] clock.
It seems that this has suffered some rot recently and is now
quite inconsistent:
* rootfs_update_timestamp() uses a different format for the time stamp
* the init scripts look for /etc/timestamp2, not /etc/timestamp which
is created with the image
The attached patch makes this consistent and the system clock now works
much better (about as good as a machine without a hardware clock can!)
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
[-- Attachment #2: 0001-Make-etc-timestamp-usage-consistent-for-machines-w.patch --]
[-- Type: text/plain, Size: 2505 bytes --]
From 20ffc320d37895028ed5c3d2a5e13c76aba0a934 Mon Sep 17 00:00:00 2001
From: Gary Thomas <gary@mlbassoc.com>
Date: Wed, 3 Nov 2010 06:52:28 -0600
Subject: [PATCH] Make /etc/timestamp usage consistent (for machines without hardware clocks)
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
meta/classes/image.bbclass | 4 ++--
.../initscripts/initscripts-1.0/bootmisc.sh | 4 ++--
.../initscripts/initscripts-1.0/save-rtc.sh | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 3db34ac..0a6df8e 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -183,7 +183,7 @@ zap_root_password () {
}
create_etc_timestamp() {
- date +%2m%2d%2H%2M%Y >${IMAGE_ROOTFS}/etc/timestamp
+ date +%Y%m%d%2H%2M >${IMAGE_ROOTFS}/etc/timestamp
}
# Turn any symbolic /sbin/init link into a file
@@ -217,7 +217,7 @@ set_image_autologin () {
# Can be use to create /etc/timestamp during image construction to give a reasonably
# sane default time setting
rootfs_update_timestamp () {
- date "+%m%d%H%M%Y" >${IMAGE_ROOTFS}/etc/timestamp
+ date "+%Y%m%d%2H%2M" >${IMAGE_ROOTFS}/etc/timestamp
}
# Prevent X from being started
diff --git a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
index 162df2b..41c313a 100755
--- a/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
+++ b/meta/recipes-core/initscripts/initscripts-1.0/bootmisc.sh
@@ -65,10 +65,10 @@ fi
# If the timestamp is 1 day or more recent than the current time,
# use the timestamp instead.
/etc/init.d/hwclock.sh start
-if test -e /etc/timestamp2
+if test -e /etc/timestamp
then
SYSTEMDATE=`date "+%Y%m%d%2H%2M"`
- read TIMESTAMP < /etc/timestamp2
+ read TIMESTAMP < /etc/timestamp
NEEDUPDATE=`expr \( $TIMESTAMP \> $SYSTEMDATE + 10000 \)`
if [ $NEEDUPDATE -eq 1 ]; then
date -s $TIMESTAMP
diff --git a/meta/recipes-core/initscripts/initscripts-1.0/save-rtc.sh b/meta/recipes-core/initscripts/initscripts-1.0/save-rtc.sh
index 75e4300..3b95411 100644
--- a/meta/recipes-core/initscripts/initscripts-1.0/save-rtc.sh
+++ b/meta/recipes-core/initscripts/initscripts-1.0/save-rtc.sh
@@ -10,4 +10,4 @@
### END INIT INFO
# Update the timestamp
-date +%Y%m%d%2H%2M > /etc/timestamp2
+date +%Y%m%d%2H%2M > /etc/timestamp
--
1.6.2.5
next reply other threads:[~2010-11-03 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-03 13:58 Gary Thomas [this message]
2010-11-03 15:05 ` Inconsistent timestamp use Mark Hatle
2010-11-03 15:35 ` Saul Wold
2010-11-03 15:45 ` Gary Thomas
2010-11-03 22:34 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD16A8E.7090100@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=poky@lists.pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox