From: Saul Wold <saul.wold@intel.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 0/3] git-pull: new pull request generation and sending scripts
Date: Mon, 08 Nov 2010 16:33:59 -0800 [thread overview]
Message-ID: <4CD896F7.2000603@intel.com> (raw)
In-Reply-To: <4CD81E51.1040304@linux.intel.com>
On 11/08/2010 07:59 AM, Darren Hart wrote:
> On 11/07/2010 08:55 PM, Bruce Ashfield wrote:
>> On 10-11-07 10:18 AM, Darren Hart wrote:
>>> On 11/06/2010 11:28 AM, Darren Hart wrote:
>>>> The following patches replace the existing create-pull-request script
>>>> and create
>>>> a new send-pull-request. See 2/3 for details on the motivation and
>>>> functionality
>>>> of the new create-pull-request script.
>>>
>>> Thinking about this, I realized that the script would be usefull for
>>> just sending patches as well (for developers without a contrib branch).
>>> Perhaps the scripts should not contain "pull" in their name and the
>>> remote git branch as well as the hosting site should be both optional
>>> and configurable. These are relatively trivial changes which we could
>>> address in a subsequent series if people agree that this initial set is
>>> the right approach for our project.
>>
>> I saw these in action at the LPC, and I like the two
>> phase approach here. Since it gives a chance to edit/update
>> review before sending, and like 'git mailinfo' it creates
>> the parts you need and doesn't actually do anything
>> without a second command :)
>>
>> Having the patches via email is key for me, so I'm glad
>> to see that in place. Do we assume that discretion will
>> be used and we don't need a throttle/limit on the patches ?
>> But then again, thinking about it, 200+ patch dumps
>> to go lkml without the world ending (and it shouldn't
>> really be common here) so this probably isn't an issue.
>
> I thought a bit about ensuring proper ordering (I've made scripts wait 5
> seconds between patches before). As for abuse... well, I think it is
> unlikely - if someone wants to abuse the list, there are innumerable
> ways to go about it, this being one of the least efficient ;-)
>
I think we also need a way to only send the initial email (and not the
patches) since I work with the team to pull together multiple patches
that are already on the list and re-send the request to the Yocto alias,
I don't want to flood the list with duplicate match info.
Also on a minor nit note: can you change the Branch to include contrib/
that way it can be a cut and paste for doing some of the local git
operations.
>>
>> So definitely acked-by me.
>>
>
> Excellent - and this brings up a point I wanted to discuss. One of the
> stated reasons for doing this was to facilitate peer review. Now that I
> have Bruce's Acked-by:, I could reword the commit messages to include
> them, or Richard could add them when he does the pull, but I do think
> they should be present in the final commits to poky proper.
>
I am not sure we need to get into updating the patch or commit messages
with Acked-by lines, the email archives should suffice.
Sau!
> Richard - how would you like to see that done? My suggestion would be
> that if you accept these as they are, that you append Bruce's Acked-by
> and your Signed-off-by. If I end up having to take another pass and send
> a V2 pull request, I could confirm Bruce still agrees (in a side
> channel) and add his Acked-by.
>
> Thanks,
>
next prev parent reply other threads:[~2010-11-09 0:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 15:28 [PATCH 0/3] git-pull: new pull request generation and sending scripts Darren Hart
2010-11-06 13:35 ` [PATCH 1/3] git pull: remove the existing create_pull_request script Darren Hart
2010-11-06 13:42 ` [PATCH 2/3] git-pull: add the new create-pull-request script Darren Hart
2010-11-06 14:06 ` [PATCH 3/3] git-pull: add send-pull-request script Darren Hart
2010-11-07 15:18 ` [PATCH 0/3] git-pull: new pull request generation and sending scripts Darren Hart
[not found] ` <4CD782A9.8080201@windriver.com>
2010-11-08 15:59 ` Darren Hart
2010-11-09 0:33 ` Saul Wold [this message]
2010-11-09 6:45 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD896F7.2000603@intel.com \
--to=saul.wold@intel.com \
--cc=dvhart@linux.intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox