From: Darren Hart <dvhart@linux.intel.com>
To: "Xu, Jiajun" <jiajun.xu@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>,
Joshua Lock <josh@linux.intel.com>
Subject: Re: [PULL] Add sanity test cases for scp/shutdown
Date: Wed, 10 Nov 2010 20:47:48 -0800 [thread overview]
Message-ID: <4CDB7574.9090808@linux.intel.com> (raw)
In-Reply-To: <D5AB6E638E5A3E4B8F4406B113A5A19A301B22C1@shsmsx501.ccr.corp.intel.com>
On 11/10/2010 07:58 PM, Xu, Jiajun wrote:
Hi Jiajun,
The *** BLURB HERE *** token is meant to be replaced with a description
of what the following patches address. Without the blurb (and without
the patch itself) there is very little information in this email about
what is being changed.
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: jxu49/master
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jxu49/master
>
> Thanks,
> Jiajun Xu<jiajun.xu@intel.com>
> ---
>
> Jiajun Xu (1):
> imagetest-qemu: Add sanity test cases for scp/shutdown in target
This patch should have followed as a response to this cover letter, but
I haven't seen it arrive in my inbox. Did you send the request using the
send-pull-request.sh script? If not, please do in the future, as having
the patches hit the list makes it much easier for others to review - and
more reviews means better code.
Looking at the diffstat below, my first thought is that this should
probably be at least 2 patches, possibly more. At least one patch per test.
And thanks for being the first to use the new create-pull-request.sh
besides me! ;-)
--
Darren
>
> meta/classes/imagetest-qemu.bbclass | 2 +-
> scripts/qemuimage-testlib | 4 +-
> scripts/qemuimage-tests/sanity/boot | 2 +-
> scripts/qemuimage-tests/sanity/dmesg | 2 +-
> scripts/qemuimage-tests/sanity/scp | 71 ++++++++++++++++++++
> scripts/qemuimage-tests/sanity/shutdown | 70 +++++++++++++++++++
> scripts/qemuimage-tests/sanity/ssh | 2 +-
> .../scenario/qemuarm/poky-image-sato | 2 +
> .../scenario/qemuarm/poky-image-sdk | 2 +
> .../scenario/qemumips/poky-image-sato | 2 +
> .../scenario/qemumips/poky-image-sdk | 2 +
> .../scenario/qemuppc/poky-image-sato | 2 +
> .../scenario/qemuppc/poky-image-sdk | 2 +
> .../scenario/qemux86-64/poky-image-minimal | 1 +
> .../scenario/qemux86-64/poky-image-sato | 5 ++
> .../scenario/qemux86-64/poky-image-sdk | 5 ++
> .../scenario/qemux86/poky-image-sato | 2 +
> .../scenario/qemux86/poky-image-sdk | 2 +
> 18 files changed, 175 insertions(+), 5 deletions(-)
> create mode 100755 scripts/qemuimage-tests/sanity/scp
> create mode 100755 scripts/qemuimage-tests/sanity/shutdown
> create mode 100644 scripts/qemuimage-tests/scenario/qemux86-64/poky-image-minimal
> create mode 100644 scripts/qemuimage-tests/scenario/qemux86-64/poky-image-sato
> create mode 100644 scripts/qemuimage-tests/scenario/qemux86-64/poky-image-sdk
>
> Best Regards,
> Jiajun
>
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
--
Darren Hart
Embedded Linux Kernel
prev parent reply other threads:[~2010-11-11 4:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 3:58 [PULL] Add sanity test cases for scp/shutdown Xu, Jiajun
2010-11-11 4:47 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDB7574.9090808@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=jiajun.xu@intel.com \
--cc=josh@linux.intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox