Poky Project Discussions
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: poky@yoctoproject.org
Subject: Re: [PATCH 0/1] Add blktrace package
Date: Mon, 22 Nov 2010 14:12:13 -0800	[thread overview]
Message-ID: <4CEAEABD.8070402@intel.com> (raw)
In-Reply-To: <cover.1290463270.git.tom.zanussi@intel.com>

On 11/22/2010 02:01 PM, Tom Zanussi wrote:
> Add blktrace, one of the tracing/profiling tools mentioned in the Yocto v1.0
> tracing/profiling tools list posted here:
>
> https://lists.yoctoproject.org/pipermail/yocto/2010-November/000281.html
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: tzanussi/traceprof
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=tzanussi/traceprof
>
> Thanks,
>      Tom Zanussi<tom.zanussi@intel.com>
> ---
>
>
> Tom Zanussi (1):
>    blktrace: new package
>
>   .../conf/distro/include/poky-default-revisions.inc |    1 +
>   meta/recipes-core/tasks/task-poky-tools.bb         |    3 +-
>   .../blktrace/blktrace/blktrace-makefile.patch      |   53 ++++++++++++++++++++
>   meta/recipes-kernel/blktrace/blktrace_git.bb       |   22 ++++++++
>   4 files changed, 78 insertions(+), 1 deletions(-)
>   create mode 100644 meta/recipes-kernel/blktrace/blktrace/blktrace-makefile.patch
>   create mode 100644 meta/recipes-kernel/blktrace/blktrace_git.bb
>
Tom,

A very quick review shows that the LICENSE metadata is too GENERIC, 
should specify the version also.

Additionally, you do not have any SCR_URI[md5] or SRC_URI[sha256] 
metadata which is now required. These are new requirements for 1.0.

Sau!

> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>



  parent reply	other threads:[~2010-11-22 22:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 22:01 [PATCH 0/1] Add blktrace package Tom Zanussi
2010-11-22 21:13 ` [PATCH 1/1] blktrace: new package Tom Zanussi
2010-11-22 22:12 ` Saul Wold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-11-22 23:10 [PATCH 0/1] Add blktrace package Tom Zanussi
2010-11-23  0:19 ` Tian, Kevin
2010-11-23  5:40   ` Tom Zanussi
2010-11-23  6:03 Tom Zanussi
2010-11-29 22:46 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CEAEABD.8070402@intel.com \
    --to=saul.wold@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox