Poky Project Discussions
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] blktrace: new package
Date: Mon, 22 Nov 2010 18:09:44 -0700	[thread overview]
Message-ID: <4CEB1458.9070503@mentor.com> (raw)
In-Reply-To: <01abe3ae64c0ee6fde2fc813abe6e8ca39dc0720.1290467442.git.tom.zanussi@intel.com>

On 11/22/2010 04:07 PM, Tom Zanussi wrote:
> Add blktrace, a tool for generating traces of the I/O traffic on block
> devices.
[snip]
> diff --git a/meta/recipes-core/tasks/task-poky-tools.bb b/meta/recipes-core/tasks/task-poky-tools.bb
> index 0a2533c..90361ba 100644
> --- a/meta/recipes-core/tasks/task-poky-tools.bb
> +++ b/meta/recipes-core/tasks/task-poky-tools.bb
> @@ -46,7 +46,8 @@ RDEPENDS_task-poky-tools-profile = "\
>   RRECOMMENDS_task-poky-tools-profile = "\
>       perf \
>       trace-cmd \
> -    kernel-module-oprofile"
> +    kernel-module-oprofile \
> +    blktrace"

Can I suggest making this:
     blktrace \
"
?  That's usually how frequently added-to variables are treated, or 
should be imho.

-- 
Tom Rini
Mentor Graphics Corporation


  reply	other threads:[~2010-11-23  1:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 23:10 [PATCH 0/1] Add blktrace package Tom Zanussi
2010-11-22 23:07 ` [PATCH 1/1] blktrace: new package Tom Zanussi
2010-11-23  1:09   ` Tom Rini [this message]
2010-11-23  5:41     ` Tom Zanussi
2010-11-23  0:19 ` [PATCH 0/1] Add blktrace package Tian, Kevin
2010-11-23  5:40   ` Tom Zanussi
  -- strict thread matches above, loose matches on Subject: below --
2010-11-23  6:03 Tom Zanussi
2010-11-23  6:01 ` [PATCH 1/1] blktrace: new package Tom Zanussi
2010-11-22 22:01 [PATCH 0/1] Add blktrace package Tom Zanussi
2010-11-22 21:13 ` [PATCH 1/1] blktrace: new package Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CEB1458.9070503@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox