From: Tom Rini <tom_rini@mentor.com>
To: poky@yoctoproject.org
Subject: Re: [PATCH 5/5] poky.conf: whitelist shell variables which are volatile to build system
Date: Tue, 23 Nov 2010 09:09:30 -0700 [thread overview]
Message-ID: <4CEBE73A.5050502@mentor.com> (raw)
In-Reply-To: <0d30dc$k8jjru@orsmga001.jf.intel.com>
On 11/22/2010 11:14 PM, Kevin Tian wrote:
> Bitbake preserves a list of good shell variables which are required by some
> shell based tasks. When scheduling a new shell task, bitbake always appends
> all those shell variables which become a trouble for task checksum, because
> most of those variables (GNOME_KEYRING_PID, XDG_SESSION_COOKIE, etc.) are
> specific to the build system and desktop session.
>
> Previously I came up an approach to explicitly seperate external shell variables
> from the ones defined by bitbake, which however ends up to be complex.
>
> So here I simply whitelist all preserved shell variables from current definition.
> This should allow wider test on sstate when the better option is under discussion.
>
> Signed-off-by: Kevin Tian<kevin.tian@intel.com>
> ---
> meta/conf/distro/poky.conf | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/conf/distro/poky.conf b/meta/conf/distro/poky.conf
> index ae13d9a..dd29d9d 100644
> --- a/meta/conf/distro/poky.conf
> +++ b/meta/conf/distro/poky.conf
> @@ -144,4 +144,5 @@ require conf/distro/include/distro_tracking_fields.inc
> # Setup our hash policy
> BB_SIGNATURE_HANDLER = "basic"
> BB_HASHTASK_WHITELIST = "(.*-cross$|.*-native$|.*-cross-initial$|.*-cross-intermediate$|^virtual:native:.*|^virtual:nativesdk:.*)"
> -BB_HASHBASE_WHITELIST = "TMPDIR FILE PATH PWD TIME DATE BBPATH OEROOT DL_DIR SSTATE_DIR THISDIR _"
> +BB_HASHBASE_WHITELIST = "TMPDIR FILE TIME DATE BBPATH OEROOT DL_DIR SSTATE_DIR THISDIR _"
> +BB_HASHBASE_WHITELIST += "PATH PWD COLORTERM DBUS_SESSION_BUS_ADDRESS DESKTOP_SESSION DESKTOP_STARTUP_ID DISPLAY GNOME_KEYRING_PID GNOME_KEYRING_SOCKET GPG_AGENT_INFO GTK_RC_FILES HOME LANG LOGNAME SESSION_MANAGER SHELL SSH_AUTH_SOCK TERM USER USERNAME XAUTHORITY XDG_DATA_DIRS XDG_SESSION_COOKIE http_proxy ftp_proxy https_proxy all_proxy ALL_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK GIT_PROXY_COMMAND"
Looking over our signature code you may also need:
FILE_DIRNAME PARALLEL_MAKE MIRRORS PREMIRRORS SSH_TTY SSH_CLIENT
SSH_CONNECTION SESSION_MANAGER GTK_RC_FILES GREP_OPTIONS
and you have SSH_AUTH_SOCK listed twice (can I suggest splitting this
into more lines?).
--
Tom Rini
Mentor Graphics Corporation
next prev parent reply other threads:[~2010-11-23 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 6:14 [PATCH 5/5] poky.conf: whitelist shell variables which are volatile to build system Kevin Tian
2010-11-23 16:09 ` Tom Rini [this message]
2010-11-23 17:38 ` Paul Eggleton
-- strict thread matches above, loose matches on Subject: below --
2010-11-23 6:14 Kevin Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CEBE73A.5050502@mentor.com \
--to=tom_rini@mentor.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox