From: Scott Garman <scott.a.garman@intel.com>
To: Chris Larson <clarson@kergoth.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: About the operator "??="
Date: Mon, 13 Dec 2010 08:24:26 -0800 [thread overview]
Message-ID: <4D0648BA.7040005@intel.com> (raw)
In-Reply-To: <AANLkTikVWrJd3CCtFOokTh=B2HQRO1v0qZRVGdBr_52O@mail.gmail.com>
On 12/10/2010 03:58 PM, Chris Larson wrote:
> On Fri, Dec 10, 2010 at 4:42 PM, Richard Purdie<rpurdie@linux.intel.com> wrote:
>> On Thu, 2010-12-09 at 22:44 +0800, Xu, Dongxiao wrote:
>>> I made the following patch (setVarFlag.patch) to move everything in
>>> setVar to setVarFlag, please help to review it.
>>>
>>> Please note one place that I modified, see the indent of
>>> "self._seen_overrides[override].add( var )", I thought it was a bug in
>>> original code.
>>
>> No, its not. Its making sure [override] exists before trying to add var
>> to it. It could also be:
>>
>> if override not in self._seen_overrides:
>> self._seen_overrides[override] = set(var)
>> else:
>> self._seen_overrides[override].add( var )
>>
>
> For master, we can use defaultdict for that sort of thing. What's
> poky's current python version requirement?
2.6, so using defaultdict should be fine.
Scott
--
Scott Garman
Embedded Linux Distro Engineer - Yocto Project
next prev parent reply other threads:[~2010-12-13 16:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 1:57 About the operator "??=" Xu, Dongxiao
2010-12-08 10:30 ` Richard Purdie
2010-12-08 11:35 ` Tian, Kevin
2010-12-08 11:59 ` Xu, Dongxiao
2010-12-08 14:37 ` Richard Purdie
2010-12-09 3:32 ` Xu, Dongxiao
2010-12-09 4:57 ` Tian, Kevin
2010-12-09 7:59 ` Xu, Dongxiao
2010-12-09 11:24 ` Richard Purdie
2010-12-09 12:13 ` Xu, Dongxiao
2010-12-09 12:45 ` Richard Purdie
2010-12-09 14:44 ` Xu, Dongxiao
2010-12-10 23:42 ` Richard Purdie
2010-12-10 23:58 ` Chris Larson
2010-12-13 16:24 ` Scott Garman [this message]
2010-12-11 2:48 ` Xu, Dongxiao
2010-12-08 12:49 ` Tian, Kevin
2010-12-08 13:02 ` Xu, Dongxiao
-- strict thread matches above, loose matches on Subject: below --
2010-12-08 3:00 Xu, Dongxiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D0648BA.7040005@intel.com \
--to=scott.a.garman@intel.com \
--cc=clarson@kergoth.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox