Poky Project Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Jingdong Lu <jingdong.lu@windriver.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/3] Fix failures of LSB.
Date: Tue, 21 Dec 2010 16:41:32 -0800	[thread overview]
Message-ID: <4D11493C.6050207@linux.intel.com> (raw)
In-Reply-To: <cover.1292925066.git.jingdong.lu@windriver.com>

On 12/21/2010 01:54 AM, Jingdong Lu wrote:
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: jingdonglu/distro
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro
>
> Thanks,
>      Jingdong Lu<jingdong.lu@windriver.com>
> ---
>

Jingdong,



Why do you need the do_install?  Can the standard do_install not work 
correctly for this recipe?

Thanks
    Sau!
>
> Jingdong Lu (3):
>    perl: Add GDBM_File into perl extension
>    gcc: Add "--enable-clocale=gnu" option explicitly
>    mailx: Add mailx
>
>   meta/recipes-devtools/gcc/gcc-configure-common.inc |    2 +-

We are reviewing the impact of the gcc clocale=gnu

>   meta/recipes-devtools/perl/perl-5.8.8/config.sh    |    2 +-
This on is OK

>   meta/recipes-extended/mailx/mailx_12.4.bb          |   18 ++++++++++++++++++
Can you please add a SUMMARY and SRC_URI checksums to the mailx recipe.

Is the PREFIX=/usr correct?  I note in other there is a ${D} or 
${D}${prefix}, please make sure you have the correct location here.

Please re-sumbit a v2 patch set.

Sau!

>   3 files changed, 20 insertions(+), 2 deletions(-)
>   create mode 100644 meta/recipes-extended/mailx/mailx_12.4.bb
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>



  parent reply	other threads:[~2010-12-22  0:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21  9:54 [PATCH 0/3] Fix failures of LSB Jingdong Lu
2010-12-21  9:54 ` [PATCH 1/3] perl: Add GDBM_File into perl extension Jingdong Lu
2010-12-21  9:54 ` [PATCH 2/3] gcc: Add "--enable-clocale=gnu" option explicitly Jingdong Lu
2010-12-21  9:54 ` [PATCH 3/3] mailx: Add mailx Jingdong Lu
2010-12-22  0:41 ` Saul Wold [this message]
2010-12-22  9:53   ` [PATCH 0/3] Fix failures of LSB Lu Jingdong
2010-12-22 11:11     ` Richard Purdie
2010-12-22 15:21     ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D11493C.6050207@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=jingdong.lu@windriver.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox