Poky Project Discussions
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Mei Lei <lei.mei@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/3]distrodata.bbcalss: To get more precise upstream version for pkg report system
Date: Wed, 22 Dec 2010 08:46:05 -0800	[thread overview]
Message-ID: <4D122B4D.9070204@intel.com> (raw)
In-Reply-To: <cover.1293023813.git.lei.mei@intel.com>

On 12/22/2010 05:22 AM, Mei Lei wrote:
> There are some changes to get more recipes upstream version and to generate some necessary data for pkg report system.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: lmei3/pkg-report-system
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lmei3/pkg-report-system
>
> Thanks,
>      Mei Lei<lei.mei@intel.com>
> ---
>
Lei:

There are various issues with these patches please see my comments below

>
> Mei Lei (3):
>    distrodata.bbclass: Change for package report system
Not sure why you needed to add a logpath2 as you are using the same 
LOG_DIR var as logpath. Are you intending to create a separate directory.

Is there a reason you need to have each package into in separate files? 
Can your tool not read 1 larger flat file then we can just use 1 output 
format for the spreadsheet

>    base.bbclass: Add inherit information for checkpkg task
We don't want to inherit the distrodata  by default, you can add this to 
your local.conf

>    bitbake.conf: Change the GNU_MIRROR to get more precise result
>
Not sure how this gives a more precise result, gnu and pub/gnu are the 
same location, one is linked to the other.

Sau!

>   meta/classes/base.bbclass       |    4 +-
>   meta/classes/distrodata.bbclass |   44 +++++++++++++++++++++++++++++++-------
>   meta/conf/bitbake.conf          |    2 +-
>   3 files changed, 39 insertions(+), 11 deletions(-)
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>



  parent reply	other threads:[~2010-12-22 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-22 13:22 [PATCH 0/3]distrodata.bbcalss: To get more precise upstream version for pkg report system Mei Lei
2010-12-22 13:22 ` [PATCH 1/3] distrodata.bbclass: Change for package " Mei Lei
2010-12-22 13:23 ` [PATCH 2/3] base.bbclass: Add inherit information for checkpkg task Mei Lei
2010-12-22 13:23 ` [PATCH 3/3] bitbake.conf: Change the GNU_MIRROR to get more precise result Mei Lei
2010-12-22 16:46 ` Saul Wold [this message]
2010-12-23  2:03   ` [PATCH 0/3]distrodata.bbcalss: To get more precise upstream version for pkg report system Mei, Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D122B4D.9070204@intel.com \
    --to=saul.wold@intel.com \
    --cc=lei.mei@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox