From: Saul Wold <saul.wold@intel.com>
To: poky@yoctoproject.org
Subject: Re: [PATCH 2/3] glib-2.0: fix g_once_init_enter compile failure
Date: Fri, 31 Dec 2010 00:05:27 -0800 [thread overview]
Message-ID: <4D1D8EC7.40504@intel.com> (raw)
In-Reply-To: <cccbddda394ceb12ef99db5561216535ccca4abd.1293731824.git.dvhart@linux.intel.com>
On 12/29/2010 10:10 AM, Darren Hart wrote:
> Kernelshark trips over a compile bug in glib-2.0 addressed by Open Embedded
> back in the 2.22 timeframe. It appears to still be present in 2.27.
>
> http://www.mail-archive.com/openembedded-devel@lists.openembedded.org/msg00529.html
>
Can you add this attribution as well as Signed-off-by in the header of
the patch file directly, this will help understand with out having to
dig into the git info.
Thanks
Sau!
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> CC: Tom Zanussi<tom.zanussi@intel.com>
> ---
> .../glib-2.0-2.27.3/g_once_init_enter.patch | 13 +++++++++++++
> meta/recipes-core/glib-2.0/glib-2.0_2.27.3.bb | 6 ++++--
> 2 files changed, 17 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-core/glib-2.0/glib-2.0-2.27.3/g_once_init_enter.patch
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0-2.27.3/g_once_init_enter.patch b/meta/recipes-core/glib-2.0/glib-2.0-2.27.3/g_once_init_enter.patch
> new file mode 100644
> index 0000000..1c4ce50
> --- /dev/null
> +++ b/meta/recipes-core/glib-2.0/glib-2.0-2.27.3/g_once_init_enter.patch
> @@ -0,0 +1,13 @@
> +Index: glib-2.27.3/glib/gthread.h
> +===================================================================
> +--- glib-2.27.3.orig/glib/gthread.h
> ++++ glib-2.27.3/glib/gthread.h
> +@@ -344,7 +344,7 @@ void g_once_init_leav
> + G_INLINE_FUNC gboolean
> + g_once_init_enter (volatile gsize *value_location)
> + {
> +- if G_LIKELY ((gpointer) g_atomic_pointer_get (value_location) != NULL)
> ++ if G_LIKELY ((gpointer) g_atomic_pointer_get ((volatile gpointer *)value_location) != NULL)
> + return FALSE;
> + else
> + return g_once_init_enter_impl (value_location);
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.27.3.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.27.3.bb
> index 30e208a..a9ff3ec 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.27.3.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.27.3.bb
> @@ -1,10 +1,12 @@
> require glib.inc
>
> -PR = "r0"
> +PR = "r1"
>
> SRC_URI = "http://ftp.gnome.org/pub/GNOME/sources/glib/2.27/glib-${PV}.tar.bz2 \
> file://configure-libtool.patch \
> - file://60_wait-longer-for-threads-to-die.patch"
> + file://60_wait-longer-for-threads-to-die.patch \
> + file://g_once_init_enter.patch \
> + "
>
> SRC_URI[md5sum] = "d3e976ff92b55b6064a0eb3110f36158"
> SRC_URI[sha256sum] = "c44177b635e88639361eb1daf7aaa33315a00aaf46db5accf2f11920c7ff1919"
prev parent reply other threads:[~2010-12-31 8:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 17:57 [PATCH 0/3] tracing: trace-cmd fixes and new kernelshark recipe Darren Hart
2010-12-29 1:10 ` [PATCH 3/3] kernelshark: add ftrace gui viewer Darren Hart
2010-12-31 8:01 ` Saul Wold
2010-12-31 18:39 ` Darren Hart
2010-12-29 1:17 ` [PATCH 1/3] trace-cmd: fix cross-compilation Darren Hart
2010-12-30 21:02 ` Bruce Ashfield
2010-12-30 22:29 ` Darren Hart
2010-12-31 6:08 ` Bruce Ashfield
2010-12-31 7:41 ` Darren Hart
2010-12-31 13:12 ` Bruce Ashfield
2010-12-29 18:10 ` [PATCH 2/3] glib-2.0: fix g_once_init_enter compile failure Darren Hart
2010-12-31 8:05 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1D8EC7.40504@intel.com \
--to=saul.wold@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox