From: Darren Hart <dvhart@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 4/4] kernelshark: add ftrace gui viewer
Date: Mon, 03 Jan 2011 11:23:11 -0800 [thread overview]
Message-ID: <4D22221F.2070608@linux.intel.com> (raw)
In-Reply-To: <1294081495.17519.20236.camel@rex>
On 01/03/2011 11:04 AM, Richard Purdie wrote:
> On Tue, 2010-12-28 at 17:10 -0800, Darren Hart wrote:
>> trace-cmd/kernelshark_git.bb b/meta/recipes-kernel/trace-cmd/kernelshark_git.bb
>> new file mode 100644
>> index 0000000..781f983
>> --- /dev/null
>> +++ b/meta/recipes-kernel/trace-cmd/kernelshark_git.bb
>> @@ -0,0 +1,22 @@
>> +DESCRIPTION = "Graphical trace viewer for Ftrace"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
>> + file://kernelshark.c;beginline=6;endline=8;md5=2c22c965a649ddd7973d7913c5634a5e"
>> +
>> +PR = r0
>> +PV = "1.0.4+git${SRCPV}"
>> +
>> +DEPENDS = "gtk+"
>> +RDEPENDS = "trace-cmd"
>
> This should be RDEPENDS_${PN} I suspect. We need to be clear about which
> package has the runtime dependency.
Hi Richard, thanks for the review.
I'm missing something about how these variables are used I guess. I had
thought that being assigned inside the kernelshark_git.bb recipe would
have been sufficient to make it clear it applied to kernelshark. How
does this bleed over into other recipes?
>
>> +inherit pkgconfig
>> +
>> +SRC_URI = "git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git;protocol=git"
>> +SRCREV = "${SRCREV_pn-trace-cmd}"
>
> I'd suggest declaring that alongside the trace-cmd SRCREV definition,
> something like:
>
> TRACECMDREV ?= "xxx"
> SRCREV_pn-trace-cmd ?= "${TRACECMDREV}"
> SRCREV_pn-kernelshark ?= "${TRACECMDREV}"
If I do this, I think a trace-cmd.inc would be the right way to go.
Having kernelshark specific bits in the base trace-cmd recipe seems
backwards to me: kernelshark builds on trace-cmd, so it makes sense to
me for the extension to made in the kernelshark recipe.
--
Darren Hart
Yocto Linux Kernel
next prev parent reply other threads:[~2011-01-03 19:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 17:46 [PATCH 0/4 V2] tracing: trace-cmd fixes and new kernelshark recipe Darren Hart
2010-12-29 1:10 ` [PATCH 4/4] kernelshark: add ftrace gui viewer Darren Hart
2011-01-03 19:04 ` Richard Purdie
2011-01-03 19:23 ` Darren Hart [this message]
2011-01-03 19:31 ` Koen Kooi
2011-01-03 19:36 ` Richard Purdie
2011-01-03 19:06 ` Darren Hart
2010-12-29 1:17 ` [PATCH 1/4] trace-cmd: fix cross-compilation Darren Hart
2010-12-29 18:10 ` [PATCH 3/4] glib-2.0: fix g_once_init_enter compile failure Darren Hart
2011-01-03 17:39 ` [PATCH 2/4] trace-cmd: license file updates Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D22221F.2070608@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=poky@yoctoproject.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox