Poky Project Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: Nitin A Kamble <nitin.a.kamble@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 12/12] screenshot: fix build issue with gcc dso linking change
Date: Mon, 17 Jan 2011 21:40:51 -0600	[thread overview]
Message-ID: <4D350BC3.7030409@windriver.com> (raw)
In-Reply-To: <9e69f662636b4cd4f9c21b9e5cddf3054d9a65a0.1295304080.git.nitin.a.kamble@intel.com>

On 1/17/11 4:45 PM, Nitin A Kamble wrote:
> All the libraries needs to be specified explicitely with the new gcc dso
> linking change patch. This was causing build errors for this
> recipe. Specifying the libX11 libgdk-x11-2.0 and libgdk_pixbuf-2.0 libraries
> explicitely for linking to work without errors.
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---

...

> +Index: screenshot/Makefile.am
> +===================================================================
> +--- screenshot.orig/Makefile.am
> ++++ screenshot/Makefile.am
> +@@ -23,4 +23,4 @@ endif
> + # A standalone tool for running from a terminal and scripts
> + bin_PROGRAMS = screenshot
> + screenshot_SOURCES = main.c
> +-screenshot_LDADD = $(GTK_LIBS) libshot.la
> ++screenshot_LDADD = $(GTK_LIBS) libshot.la -lgdk-x11-2.0 -lgdk_pixbuf-2.0 -lX11

Similar to the last one.  On first look, the GTK_LIBS or libshot.la might be
incorrect causing this failure.  If it's been verified that both GTK_LIBS values
and the libshot.la match the contents of the library.... and these things are
application specific the change is fine.. I'd just like a comment explaining that.

--Mark

> diff --git a/meta/recipes-sato/screenshot/screenshot_svn.bb b/meta/recipes-sato/screenshot/screenshot_svn.bb
> index 35f3422..ff2b7c8 100644
> --- a/meta/recipes-sato/screenshot/screenshot_svn.bb
> +++ b/meta/recipes-sato/screenshot/screenshot_svn.bb
> @@ -10,8 +10,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
>  PRIORITY = "optional"
>  DEPENDS = "matchbox-panel-2"
>  PV = "0.0+svnr${SRCPV}"
> +PR = "r1"
>  
> -SRC_URI = "svn://svn.o-hand.com/repos/misc/trunk;module=${PN};proto=http"
> +SRC_URI = "svn://svn.o-hand.com/repos/misc/trunk;module=${PN};proto=http\
> +	file://dso_linking_change_build_fix.patch"
>  
>  S = ${WORKDIR}/${PN}
>  



  reply	other threads:[~2011-01-18  3:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17 22:45 [PATCH 00/12] gcc dso linking change, and related fixes Nitin A Kamble
2011-01-17 22:45 ` [PATCH 01/12] gcc_4.5.1: add DSO linking change patch Nitin A Kamble
2011-01-17 22:45 ` [PATCH 03/12] libmusicbrainz: fix the build failure caused by gcc dso linkcing change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 07/12] xtscal: fix build issue with gcc dso linking change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 04/12] oprofileui: fix the build failure after gcc dso change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 02/12] sat-solver: fix the build failure caused by gcc dso linkcing change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 05/12] settings-daemon: fix build error with new gcc dso linking change Nitin A Kamble
2011-01-17 22:45 ` [PATCH 06/12] matchbox-desktop: fix build issue with " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 09/12] fstests: " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 12/12] screenshot: " Nitin A Kamble
2011-01-18  3:40   ` Mark Hatle [this message]
2011-01-18  4:16     ` Kamble, Nitin A
2011-01-19  0:38     ` Kamble, Nitin A
2011-01-17 22:45 ` [PATCH 10/12] dates: " Nitin A Kamble
2011-01-18  3:39   ` Mark Hatle
2011-01-18  4:14     ` Kamble, Nitin A
2011-01-17 22:45 ` [PATCH 08/12] blktrace: " Nitin A Kamble
2011-01-17 22:45 ` [PATCH 11/12] matchbox-stroke: : " Nitin A Kamble
2011-01-21  0:13 ` [PATCH 00/12] gcc dso linking change, and related fixes Richard Purdie
2011-01-21 16:39   ` Kamble, Nitin A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D350BC3.7030409@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=nitin.a.kamble@intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox