Poky Project Discussions
 help / color / mirror / Atom feed
From: Scott Garman <scott.a.garman@intel.com>
To: Koen Kooi <koen@dominion.thruhere.net>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 5/9] insane.bbclass: skip checks on .la installed status
Date: Wed, 19 Jan 2011 10:27:18 -0800	[thread overview]
Message-ID: <4D372D06.3090703@intel.com> (raw)
In-Reply-To: <21D8C9BF-2F1A-479C-AF91-D7BE4ED87D44@dominion.thruhere.net>

On 01/18/2011 11:19 PM, Koen Kooi wrote:
> Op 19 jan 2011, om 05:19 heeft Scott Garman het volgende geschreven:
>
>> Enabling libtool sysroot support triggers these errors but they
>> are a valid change in behavior.
>
> Based on the RPATH discussion off-list, should we add a check for RPATH pointing to staging as well? I know RPs patches fix it, but it would be nice to catch if it starts happening again.

By staging I assume you're referring to the sysroot dir? If so, we do 
have that QA check in insane.bbclass already (see 
package_qa_check_rpath), and I have been relying on it to detect the 
problems I was reporting. This patch doesn't alter or remove that.

If I'm misunderstanding, feel free to correct me.

Scott

>>
>> Signed-off-by: Scott Garman<scott.a.garman@intel.com>
>> ---
>> meta/classes/insane.bbclass |    5 -----
>> 1 files changed, 0 insertions(+), 5 deletions(-)
>>
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index 3ab4c2c..6f06d85 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -427,11 +427,6 @@ def package_qa_check_staged(path,d):
>>              path = os.path.join(root,file)
>>              if file.endswith(".la"):
>>                  file_content = open(path).read()
>> -                # Don't check installed status for native/cross packages
>> -                if not bb.data.inherits_class("native", d) and not bb.data.inherits_class("cross", d):
>> -                    if installed in file_content:
>> -                        error_msg = "%s failed sanity test (installed) in path %s" % (file,root)
>> -                        sane = package_qa_handle_error(5, error_msg, "staging", path, d)
>>                  if workdir in file_content:
>>                      error_msg = "%s failed sanity test (workdir) in path %s" % (file,root)
>>                      sane = package_qa_handle_error(8, error_msg, "staging", path, d)
>> --
>> 1.7.1
>>
>> _______________________________________________
>> poky mailing list
>> poky@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/poky
>


-- 
Scott Garman
Embedded Linux Distro Engineer - Yocto Project


  reply	other threads:[~2011-01-19 18:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-19  4:19 [PATCH 0/9] libtool 2.4 sysroot support Scott Garman
2011-01-19  4:19 ` [PATCH 1/9] libtool: changes to enable " Scott Garman
2011-01-19 14:48   ` Richard Purdie
2011-01-19 16:05     ` Richard Purdie
2011-01-19  4:19 ` [PATCH 2/9] libtool: fix library RPATHs Scott Garman
2011-01-19  4:19 ` [PATCH 3/9] autotools.bbclass: libtool sysroot support changes Scott Garman
2011-01-19  4:19 ` [PATCH 4/9] staging.bbclass, utils.bbclass: remove la mangling code Scott Garman
2011-01-19  4:19 ` [PATCH 5/9] insane.bbclass: skip checks on .la installed status Scott Garman
2011-01-19  7:19   ` Koen Kooi
2011-01-19 18:27     ` Scott Garman [this message]
2011-01-19 19:17       ` Koen Kooi
2011-01-19  4:19 ` [PATCH 6/9] binutils: upgrade to 2.21 and add libtool sysroot support Scott Garman
2011-01-19  4:20 ` [PATCH 7/9] binutils: Fix QA staging errors for target binutils Scott Garman
2011-01-19  4:20 ` [PATCH 8/9] binutils: fix library RPATHs Scott Garman
2011-01-19  4:20 ` [PATCH 9/9] poky-default.inc: bump binutils preferred version to 2.21 Scott Garman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D372D06.3090703@intel.com \
    --to=scott.a.garman@intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox