Poky Project Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Scott Garman <scott.a.garman@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] send-pull-request: unset $TO and $CC from environment
Date: Mon, 24 Jan 2011 14:58:24 -0800	[thread overview]
Message-ID: <4D3E0410.5080608@linux.intel.com> (raw)
In-Reply-To: <8b101a50a90bb93493e747863a68248a6726637b.1295655589.git.scott.a.garman@intel.com>

On 01/21/2011 04:22 PM, Scott Garman wrote:
> Darren Hart and I discovered that when $CC is set (which
> our meta-toolchain environment script sets up), the value
> leaks into the use of this script. Unsetting $TO as well
> just to be thorough.
>
> Signed-off-by: Scott Garman<scott.a.garman@intel.com>

Thanks Scott!

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>   scripts/send-pull-request |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index 9872c0d..a66d4dc 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
>       PULL_MTA="sendmail"
>   fi
>
> +# Prevent environment leakage to these vars.
> +unset TO
> +unset CC
> +
>   usage()
>   {
>   cat<<EOM


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


  reply	other threads:[~2011-01-24 22:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-22  0:21 [PATCH 0/1] send-pull-request bugfix Scott Garman
2011-01-22  0:22 ` [PATCH 1/1] send-pull-request: unset $TO and $CC from environment Scott Garman
2011-01-24 22:58   ` Darren Hart [this message]
2011-01-28  1:30 ` [PATCH 0/1] send-pull-request bugfix Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D3E0410.5080608@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=poky@yoctoproject.org \
    --cc=scott.a.garman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox