From: Saul Wold <saul.wold@intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/5] gcc: Add "--enable-clocale=gnu" option explicitly
Date: Sun, 30 Jan 2011 13:06:55 -0800 [thread overview]
Message-ID: <4D45D2EF.6050706@intel.com> (raw)
In-Reply-To: <625BA99ED14B2D499DC4E29D8138F1504E6294E15B@shsmsx502.ccr.corp.intel.com>
On 01/30/2011 12:11 AM, Tian, Kevin wrote:
>> From: Jingdong Lu
>> Sent: Sunday, January 30, 2011 3:36 PM
>>
>> From: Jingdong Lu<jingdong.lu@windriver.com>
>>
>> Add "--enable-clocale=gun" option for gcc configuration explicitly in order to
>> make sure C++ library can use correct locale module.
>>
>> Signed-off-by: Jingdong Lu<jingdong.lu@windriver.com>
>> ---
>> meta/recipes-devtools/gcc/gcc-configure-common.inc | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-common.inc
>> b/meta/recipes-devtools/gcc/gcc-configure-common.inc
>> index 4393777..b212fdc 100644
>> --- a/meta/recipes-devtools/gcc/gcc-configure-common.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-configure-common.inc
>> @@ -27,7 +27,7 @@ EXTRA_OECONF_INTERMEDIATE ?= ""
>>
>> GCCMULTILIB = "--disable-multilib"
>>
>> -EXTRA_OECONF = "${@['--enable-clocale=generic',
>> ''][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
>> +EXTRA_OECONF = "${@['--enable-clocale=generic', '
>> --enable-clocale=gnu'][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
>> --with-gnu-ld \
>> --enable-shared \
>> --enable-languages=${LANGUAGES} \
>> --
>> 1.7.0.4
>>
>
> PR bump is expected for all gcc recipes affected by this change.
>
Yes, I agree with Kevin on this, also what is the impact to generated
binaries? Does this add any size to compiled binaries?
Sau!
> Thanks
> Kevin
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
next prev parent reply other threads:[~2011-01-30 21:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 7:36 [PATCH 0/5] [PULL] Add packages and fix failures of LSB Jingdong Lu
2011-01-30 7:36 ` [PATCH 1/5] gcc: Add "--enable-clocale=gnu" option explicitly Jingdong Lu
2011-01-30 8:11 ` Tian, Kevin
2011-01-30 21:06 ` Saul Wold [this message]
2011-01-31 4:36 ` Tian, Kevin
2011-01-30 7:36 ` [PATCH 2/5] mailx: add mailx 12.4 Jingdong Lu
2011-01-30 7:36 ` [PATCH 3/5] msmtp: add msmtp 1.4.23 Jingdong Lu
2011-01-30 7:36 ` [PATCH 4/5] cups: add cups 1.4.6 Jingdong Lu
2011-01-30 9:14 ` Koen Kooi
2011-01-30 16:01 ` Koen Kooi
2011-01-30 21:20 ` Saul Wold
2011-01-30 22:04 ` Koen Kooi
2011-01-30 7:36 ` [PATCH 5/5] libxml2: Enable "--with-legacy" for LSB test Jingdong Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D45D2EF.6050706@intel.com \
--to=saul.wold@intel.com \
--cc=kevin.tian@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox