From: Darren Hart <dvhart@linux.intel.com>
To: Gary Thomas <gary@mlbassoc.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: History and intentions of linux.inc ?
Date: Tue, 08 Feb 2011 14:03:37 -0800 [thread overview]
Message-ID: <4D51BDB9.2030508@linux.intel.com> (raw)
In-Reply-To: <4D51BA63.3020606@mlbassoc.com>
On 02/08/2011 01:49 PM, Gary Thomas wrote:
> On 02/08/2011 02:41 PM, Darren Hart wrote:
>> I've stumbled over a couple of interesting bits in the existing
>> recipes-kernel/linux/linux.inc, for example (but not limited to):
>>
>>> do_install_prepend() {
>>> if test -e arch/${ARCH}/boot/Image ; then
>>> ln -f arch/${ARCH}/boot/Image arch/${ARCH}/boot/uImage
>>> fi
>>
>> On a recent kernel, the above will overwrite a valid uImage with Image,
>> resulting in a non-bootable set of files in deploy/images.
>>
>>>
>>> if test -e arch/${ARCH}/boot/images/uImage ; then
>>> ln -f arch/${ARCH}/boot/images/uImage arch/${ARCH}/boot/uImage
>>> fi
>>
>> The arch/arm/boot/images directory does not exist on a current kernel
>> (2.6.35-linaro anyway).
>>
>>
>> Does anyone know the historical significance and/or intent of this code?
>> Are there architectures for which this does something sane? After
>> reading through linux.inc, I'm inclined to avoid using it for the
>> meta-linaro kernel, and then going after it with chainsaw.
>>
>> Anyone have anything to add before I start cutting?
>>
>
> I also found the same odd behaviour. My [simple] solution was
> to use my own linux.inc, much like there is a linux-yocto.inc,
> which totally removes do_install_prepend()
>
> I'm sure this is safe to do in the mainline meta/recipes-kernel;
> as I said the yocto kernel already has done away with the whole
> file.
>
Right, which was prompting me to start looking into whether or not
linux.inc should continue to exist in it's current form.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2011-02-08 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 21:41 History and intentions of linux.inc ? Darren Hart
2011-02-08 21:49 ` Gary Thomas
2011-02-08 22:03 ` Darren Hart [this message]
2011-02-08 22:01 ` Tom Rini
2011-02-09 1:27 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D51BDB9.2030508@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=gary@mlbassoc.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox