From: Saul Wold <saul.wold@intel.com>
To: Yu Ke <ke.yu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 2/2] xserver-nodm-init: add rootless-x support
Date: Tue, 22 Feb 2011 12:20:26 -0800 [thread overview]
Message-ID: <4D641A8A.5030802@intel.com> (raw)
In-Reply-To: <3a0ec35ea472b2ae866022ef2d3278afd33d9db8.1298390312.git.ke.yu@intel.com>
On 02/22/2011 08:00 AM, Yu Ke wrote:
> most rootless X work are already done in the kernel, xserver and
> graphics driver, this patches add the the remaining userspace setting:
>
> - create /etc/X11/Xusername to set rootless X user
> - add rootless X user to group video, tty to access /dev/tty[0-4]
> and /dev/dri/card0
> - grant rootless X user access right to /dev/input/*, /var/log
>
> Signed-off-by: Yu Ke<ke.yu@intel.com>
> ---
> .../x11-common/xserver-nodm-init.bb | 22 +++++++++++++++++++-
> .../x11-common/xserver-nodm-init/Xusername | 1 +
> .../x11-common/xserver-nodm-init/xserver-nodm | 4 +++
> 3 files changed, 26 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xusername
>
> diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init.bb b/meta/recipes-graphics/x11-common/xserver-nodm-init.bb
> index 03a6ca3..4642272 100644
> --- a/meta/recipes-graphics/x11-common/xserver-nodm-init.bb
> +++ b/meta/recipes-graphics/x11-common/xserver-nodm-init.bb
> @@ -3,10 +3,11 @@ LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> SECTION = "x11"
> PRIORITY = "optional"
> -PR = "r23"
> +PR = "r24"
> RDEPENDS_${PN} = "dbus-wait sudo"
>
> SRC_URI = "file://xserver-nodm \
> + file://Xusername \
> file://gplv2-license.patch"
>
> S = ${WORKDIR}
> @@ -17,6 +18,25 @@ do_install() {
> install -d ${D}/etc
> install -d ${D}/etc/init.d
> install xserver-nodm ${D}/etc/init.d
> + if [ "${ROOTLESS_X}" = "1" ] ; then
> + install -d ${D}/etc/X11
> + install Xusername ${D}/etc/X11
> + fi
> +}
> +
> +pkg_postinst_${PN} () {
> + if [ "x$D" != "x" ] ; then
> + exit 1
> + fi
> +
> + if [ ! -f /etc/X11/Xusername ]; then
Do you really mean to check for the file existing?
> + # create the rootless X user, and add user to group tty, video
> + username=`cat /etc/X11/Xusername`
> + adduser --disabled-password $username
> + # FIXME: use addgroup if busybox addgroup is ready
> + sed -i -e "s/^video:.*/&${username}/g" /etc/group
> + sed -i -e "s/^tty:.*/&${username}/g" /etc/group
> + fi
> }
>
> inherit update-rc.d
> diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/Xusername b/meta/recipes-graphics/x11-common/xserver-nodm-init/Xusername
> new file mode 100644
> index 0000000..db9781a
> --- /dev/null
> +++ b/meta/recipes-graphics/x11-common/xserver-nodm-init/Xusername
> @@ -0,0 +1 @@
> +yocto
Why yocto, maybe xuser would be a more generic username
> diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
> index 69ea949..d8c4ba0 100755
> --- a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
> +++ b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
> @@ -30,6 +30,10 @@ case "$1" in
> echo "Starting Xserver"
> if [ -f /etc/X11/Xusername ]; then
> username=`cat /etc/X11/Xusername`
> + # setting for rootless X
> + chmod o+w /var/log
> + chmod g+r /dev/tty[0-3]
> + chmod o+rw /dev/input/*
> fi
> # Using sudo -i here has the nice side effect of making sire
> # HOME, USER and other previously problematic variables
next prev parent reply other threads:[~2011-02-22 20:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 16:00 [PATCH 0/2] rootless x support Yu Ke
2011-02-22 16:00 ` [PATCH 1/2] xf86-video-intel: add config option to support rootless X Yu Ke
2011-02-22 20:03 ` Saul Wold
2011-02-23 1:21 ` Yu Ke
2011-02-22 16:00 ` [PATCH 2/2] xserver-nodm-init: add rootless-x support Yu Ke
2011-02-22 20:20 ` Saul Wold [this message]
2011-02-23 1:23 ` Yu Ke
-- strict thread matches above, loose matches on Subject: below --
2011-02-23 2:14 [PATCH 0/2] rootless x support v2 Yu Ke
2011-02-23 2:14 ` [PATCH 2/2] xserver-nodm-init: add rootless-x support Yu Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D641A8A.5030802@intel.com \
--to=saul.wold@intel.com \
--cc=ke.yu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox