Poky Project Discussions
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: Joshua Lock <josh@linux.intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/3] base.bbclass: enable INCOMPATIBLE_LICENSE to match slight variations
Date: Fri, 25 Feb 2011 13:31:37 -0800	[thread overview]
Message-ID: <4D681FB9.9090200@intel.com> (raw)
In-Reply-To: <1298669236.11134.5.camel@scimitar>

On 02/25/2011 01:27 PM, Joshua Lock wrote:
> On Fri, 2011-02-25 at 14:26 -0600, Mark Hatle wrote:
>> Only thing I would be concerned with in this patch is a license of "GPLv3 w/
>> exception"  (I'm not sure how we address that, but there are cases where things
>> are GPLv3, but the exception may allow someone to use the component where they
>> would not normally allow for GPLv3.)  I'm not exactly sure the best way to
>> handle this...
>
> Hmm, fair point - I hadn't thought of that.
>
> I can't think of a better way to do this that doesn't involve
> implementing a fragile test, in which case we'd probably best ignore
> this and patch three from this series.
>
I was also looking at this, and wondering if it was appropriate, so you 
only want me to pull patch 2 of this set?

Patch 3 is still sort of appropriate, that's what I set for my testing 
right now.  But as Mark points out it's far from perfect and right now I 
am having failures building without GPLv3!

Sau!

> Cheers,
> Joshua
>>
>> --Mark
>>
>> On 2/25/11 1:13 PM, Joshua Lock wrote:
>>> From: Joshua Lock<josh@linux.intel.com>
>>>
>>> Add a greedy any-character match to INCOMPATIBLE_LICENSE so that we can match
>>> different permutations of that license, i.e. if INCOMPATIBLE_LICENSE is set
>>> to GPLv3 we should also match GPLv3+
>>>
>>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>>> ---
>>>   meta/classes/base.bbclass |    9 ++++++++-
>>>   1 files changed, 8 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
>>> index a674f52..3ff11d3 100644
>>> --- a/meta/classes/base.bbclass
>>> +++ b/meta/classes/base.bbclass
>>> @@ -345,7 +345,14 @@ python () {
>>>                   raise bb.parse.SkipPackage("incompatible with machine %s" % this_machine)
>>>
>>>
>>> -        dont_want_license = bb.data.getVar('INCOMPATIBLE_LICENSE', d, 1)
>>> +        dont_want_license = bb.data.getVar('INCOMPATIBLE_LICENSE', d, True)
>>> +        # If dont_want_license is set add a greedy any-character match
>>> +        # to it (if not already set) so that we can match permutations
>>> +        # of that license. i.e. if dont_want_license is set to GPLv3 we
>>> +        # also want to match GPLv3+
>>> +        if dont_want_license and not dont_want_license.endswith('.+'):
>>> +	    dont_want_license = dont_want_license + '.+'
>>> +
>>>           if dont_want_license and not pn.endswith("-native") and not pn.endswith("-cross") and not pn.endswith("-cross-initial") and not pn.endswith("-cross-intermediate"):
>>>               hosttools_whitelist = (bb.data.getVar('HOSTTOOLS_WHITELIST_%s' % dont_want_license, d, 1) or "").split()
>>>               lgplv2_whitelist = (bb.data.getVar('LGPLv2_WHITELIST_%s' % dont_want_license, d, 1) or "").split()
>>
>> _______________________________________________
>> poky mailing list
>> poky@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/poky
>



  reply	other threads:[~2011-02-25 21:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-25 19:13 [PATCH 0/3] A few GUI related patches, including a bug fix Joshua Lock
2011-02-25 19:13 ` [PATCH 1/3] base.bbclass: enable INCOMPATIBLE_LICENSE to match slight variations Joshua Lock
2011-02-25 20:26   ` Mark Hatle
2011-02-25 21:27     ` Joshua Lock
2011-02-25 21:31       ` Saul Wold [this message]
2011-02-25 19:13 ` [PATCH 2/3] bitbake/hob: only show one progress dialog when changing machine Joshua Lock
2011-02-25 19:14 ` [PATCH 3/3] bitbake/hob: add checkbox to disable GPLv3 recipes Joshua Lock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D681FB9.9090200@intel.com \
    --to=saul.wold@intel.com \
    --cc=josh@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox