From: Khem Raj <raj.khem@gmail.com>
To: Yu Ke <ke.yu@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] x11vnc: fix the endian issue in mips for bug 782
Date: Fri, 04 Mar 2011 08:33:53 -0800 [thread overview]
Message-ID: <4D711471.104@gmail.com> (raw)
In-Reply-To: <81b14a20bb1ed302b6befc872535c35659c57725.1299247293.git.ke.yu@intel.com>
On 3/4/2011 6:04 AM, Yu Ke wrote:
> x11vnc use LIBVNCSERVER_WORDS_BIGENDIAN to handle the endian, however
> it is not set correctly when cross-compile for mips, thus x11vnc mips
> does not work correctly.
>
> meanwhile, x11vnc has the autconf macro AC_C_BIGENDIAN which can
> handle the endian correctly. so this patch replace the
> LIBVNCSERVER_WORDS_BIGENDIAN with WORDS_BIGENDIAN (generated by
> AC_C_BIGENDIAN) to fix this issue.
>
> this patch fix the bug [YOCTO #782]
>
> this appraoch is suggested by Khem Raj
>
> CC: Khem Raj<raj.khem@gmail.com>
>
> Signed-off-by: Yu Ke<ke.yu@intel.com>
look better
> ---
> .../recipes-graphics/x11vnc/files/endian-fix.patch | 22 ++++++++++++++++++++
> meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb | 5 +++-
> 2 files changed, 26 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-graphics/x11vnc/files/endian-fix.patch
>
> diff --git a/meta/recipes-graphics/x11vnc/files/endian-fix.patch b/meta/recipes-graphics/x11vnc/files/endian-fix.patch
> new file mode 100644
> index 0000000..0b5e470
> --- /dev/null
> +++ b/meta/recipes-graphics/x11vnc/files/endian-fix.patch
> @@ -0,0 +1,22 @@
> +libvncserver: replace LIBVNCSERVER_WORDS_BIGENDIAN with WORDS_BIGENDIAN
> +
> +since macro AC_C_BIGENDIAN is used in autoconf and WORDS_BIGENDIAN is
> +automatically set for different arch, it is better to use WORDS_BIGENDIAN
> +instead of LIBVNCSERVER_WORDS_BIGENDIAN, which cuase issue in mips.
> +
> +Signed-off-by: Yu Ke<ke.yu@intel.com>
> +
> +diff --git a/libvncserver/main.c b/libvncserver/main.c
> +index b6bd930..8bbb7bf 100644
> +--- a/libvncserver/main.c
> ++++ b/libvncserver/main.c
> +@@ -47,7 +47,7 @@ static MUTEX(extMutex);
> +
> + static int rfbEnableLogging=1;
> +
> +-#ifdef LIBVNCSERVER_WORDS_BIGENDIAN
> ++#ifdef WORDS_BIGENDIAN
> + char rfbEndianTest = (1==0);
> + #else
> + char rfbEndianTest = (1==1);
> +
> diff --git a/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb b/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb
> index f5a6662..f92eb49 100644
> --- a/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb
> +++ b/meta/recipes-graphics/x11vnc/x11vnc_0.9.12.bb
> @@ -9,8 +9,11 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f \
>
> DEPENDS = "openssl virtual/libx11 libxext avahi jpeg zlib"
>
> +PR = "r1"
> +
> SRC_URI = "${SOURCEFORGE_MIRROR}/libvncserver/x11vnc-${PV}.tar.gz\
> - file://starting-fix.patch"
> + file://starting-fix.patch \
> + file://endian-fix.patch "
>
> SRC_URI[md5sum] = "1498a68d02aa7b6c97bf746c073c8d00"
> SRC_URI[sha256sum] = "60a7cceee2c9a5f1c854340b2bae13f975ac55906237042f81f795b28a154a79"
prev parent reply other threads:[~2011-03-04 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 14:04 [PATCH 0/1] BUG782 fix: vnc server issue in mips - v2 Yu Ke
2011-03-04 14:04 ` [PATCH 1/1] x11vnc: fix the endian issue in mips for bug 782 Yu Ke
2011-03-04 16:33 ` Khem Raj [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D711471.104@gmail.com \
--to=raj.khem@gmail.com \
--cc=ke.yu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox