Poky Project Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Tom Zanussi <tom.zanussi@intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 2/2] documentation: Kernel Manual fixes
Date: Mon, 14 Mar 2011 09:32:17 -0700	[thread overview]
Message-ID: <4D7E4311.2040503@linux.intel.com> (raw)
In-Reply-To: <b3358d9bde3fd31dbca76323337d248dacce8c5b.1300081427.git.tom.zanussi@intel.com>



On 03/13/2011 10:50 PM, Tom Zanussi wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>

Thanks Tom, you beat me to it.

> Upgraded to reflect 1.0 usage rather than 0.90 usage, and some other
> clarifications and minor changes.

Only one minor nitpic below:

>
> Signed-off-by: Tom Zanussi<tom.zanussi@intel.com>
> ---
>   documentation/kernel-manual/kernel-how-to.xml |  120 +++++++++++++------------
>   1 files changed, 61 insertions(+), 59 deletions(-)
>
> diff --git a/documentation/kernel-manual/kernel-how-to.xml b/documentation/kernel-manual/kernel-how-to.xml
> index abb19f2..fdfda40 100644
> --- a/documentation/kernel-manual/kernel-how-to.xml
> +++ b/documentation/kernel-manual/kernel-how-to.xml
> @@ -425,18 +425,18 @@ repository.
>

...

>               <para>
> -                This section provides an example for creating a BSP that is based on an existing, and hopefully,
> -                similar one.
> -                Follow these steps and keep in mind your particular situation and differences:
> +                This section provides an example for creating a BSP
> +                that is based on an existing, and hopefully, similar
> +                one.  It assumes you'll be using a local kernel

We should void using contractions in formal documentation

s/you'll/you will/

> +                repository and will be pointing the kernel recipe at
> +                that.  Follow these steps and keep in mind your
> +                particular situation and differences:
>
>               <orderedlist>
>                   <listitem><para>
> @@ -1016,16 +1019,10 @@ That's it. Configure and build.
>                   </para>
>
>                   <para>
> -                    You can start with something in<filename>meta/conf/machine</filename>.
> -                    Or,<filename>meta-emenlow/conf/machine</filename>  has an example in its own layer.
> +                    You can start with something in<filename>meta/conf/machine</filename>  -<filename>meta/conf/machine/atom-pc.conf</filename>  for example.  Or, you can start with a machine configuration from any of the BSP layers in the meta-intel repository at<ulink url='http://git.pokylinux.org/cgit/cgit.cgi/meta-intel/'></ulink>, such as<filename>meta-intel/meta-emenlow/conf/machine/emenlow.conf</filename>.

I presume we're using some line length limit in our documentation?


Otherwise looks good to me.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


  reply	other threads:[~2011-03-14 16:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-14  5:50 [PATCH 0/2] BSP Guide and Kernel Manual updates Tom Zanussi
2011-03-14  5:50 ` [PATCH 1/2] documentation: BSP Developer's Guide fixes Tom Zanussi
2011-03-14 16:33   ` Darren Hart
2011-03-14  5:50 ` [PATCH 2/2] documentation: Kernel Manual fixes Tom Zanussi
2011-03-14 16:32   ` Darren Hart [this message]
2011-03-14 16:51     ` Rifenbark, Scott M
2011-03-14 21:10       ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D7E4311.2040503@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=poky@yoctoproject.org \
    --cc=tom.zanussi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox