From: Kang Kai <Kai.Kang@windriver.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 1/1] PATCH: fix Bug 812 about slang
Date: Tue, 15 Mar 2011 11:23:54 +0800 [thread overview]
Message-ID: <4D7EDBCA.6060009@windriver.com> (raw)
In-Reply-To: <4D7EBE19.6080603@linux.intel.com>
On 2011年03月15日 09:17, Saul Wold wrote:
>
> Kang,
>
> The proper first line of a commit (commit subject line) should contain
> the package name followed by what you have done in this commit.
>
> Also, the bug # should not be in the first line, it should be in the
> Body of the commit message in the [YOCTO #XXX] format.
>
> So your commit message should read something like:
>
> slang: Export INST_LIB_DIR in do_install to fix compile problems
>
> Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings
> Fixes [YOCTO #812]
>
> Signed-off-by: Kang Kai<kai.kang@windriver.com>
>
Sau!
Thank you very much, I will obey the rule next time.
And is there any document about the rules, then I can be more careful
about my mails' format.
Regards,
Kang Kai
>
>
> On 03/13/2011 11:29 PM, Kang Kai wrote:
>> From: Kang Kai<kai.kang@windriver.com>
>>
>> Export "INST_LIB_DIR" to slang/slsh to fix cross compile warnings
>>
>> Add necessary files to run slsh.
>>
>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
>> ---
>> meta/recipes-extended/slang/slang_2.2.2.bb | 8 +++++++-
>> 1 files changed, 7 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-extended/slang/slang_2.2.2.bb
>> b/meta/recipes-extended/slang/slang_2.2.2.bb
>> index 7fe76af..8459e24 100644
>> --- a/meta/recipes-extended/slang/slang_2.2.2.bb
>> +++ b/meta/recipes-extended/slang/slang_2.2.2.bb
>> @@ -10,7 +10,7 @@ to recode S-Lang procedures in C if you need to."
>> SECTION = "libs"
>> PRIORITY = "optional"
>> DEPENDS = "pcre"
>> -PR = "r0"
>> +PR = "r1"
>>
>> LICENSE = "GPL Artistic"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>> @@ -23,3 +23,9 @@ inherit autotools
>>
>> SRC_URI[md5sum] = "974437602a781cfe92ab61433dd16d03"
>> SRC_URI[sha256sum] =
>> "cfaf8551fa3855f9b0043309bb553ef6d457f931b404df5a6ba6a5a69371fc42"
>> +
>> +do_install() {
>> + oe_runmake install DESTDIR=${D} -e
>> 'INST_LIB_DIR=${STAGING_DIR_HOST}/usr/lib'
>> +}
>> +
>> +FILES_${PN} += "/usr/share/slsh/"
next prev parent reply other threads:[~2011-03-15 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 6:29 [PATCH 0/1] PATCH RESEND: fix Bug 812 about slang Kang Kai
2011-03-14 6:29 ` [PATCH 1/1] PATCH: " Kang Kai
2011-03-15 1:17 ` Saul Wold
2011-03-15 3:23 ` Kang Kai [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-10 6:07 [PATCH 0/1] PATCH:fix Bug 812 Kang Kai
2011-03-10 6:07 ` [PATCH 1/1] PATCH: fix Bug 812 about slang Kang Kai
2011-03-11 6:50 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7EDBCA.6060009@windriver.com \
--to=kai.kang@windriver.com \
--cc=poky@yoctoproject.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox