Poky Project Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH A] n450: add optimization flags to gtk+ for n450 to avoid gcc core2 bug
Date: Wed, 16 Mar 2011 15:34:21 -0700	[thread overview]
Message-ID: <4D813AED.4030605@linux.intel.com> (raw)
In-Reply-To: <4D813515.2030801@linux.intel.com>



On 03/16/2011 03:09 PM, Darren Hart wrote:
> On 03/16/2011 02:49 PM, Darren Hart wrote:
>>
>> Fixes [YOCTO #853]
>>
>> Without these added optimization flags, the matchbox-panel (and
>> possibly other)
>> applications would segfault. This patch applies the change only to the
>> gtk+
>> recipe for the n450 bsp.
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> CC: Ke Yu<ke.yu@intel.com>
>> ---
>> meta-n450/recipes-gnome/gtk+/gtk+_2.22.1.bbappend | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>> create mode 100644 meta-n450/recipes-gnome/gtk+/gtk+_2.22.1.bbappend
>>
>> diff --git a/meta-n450/recipes-gnome/gtk+/gtk+_2.22.1.bbappend
>> b/meta-n450/recipes-gnome/gtk+/gtk+_2.22.1.bbappend
>> new file mode 100644
>> index 0000000..3af4187
>> --- /dev/null
>> +++ b/meta-n450/recipes-gnome/gtk+/gtk+_2.22.1.bbappend
>> @@ -0,0 +1,2 @@
>> +#-fomit-frame-pointer in default FULL_OPTIMIZATION will cause
>> matchbox-panel segfault on n450
>> +FULL_OPTIMIZATION_n450 = "-fexpensive-optimizations
>> -frename-registers -O2 -ggdb -feliminate-unused-debug-types"
>
>
> Note that this patch only addresses the problem for the n450, and it
> would remain on the atom-pc. If we don't want to take Patch B, then we
> would need another solution for atom-pc. The only thing that comes to
> mind would be to add the above to the core gtk+ recipe in the form:
>
> #-fomit-frame-pointer in default FULL_OPTIMIZATION will cause
> matchbox-panel segfault on atom-pc
> FULL_OPTIMIZATION_atom-pc = "-fexpensive-optimizations
> -frename-registers -O2 -ggdb -feliminate-unused-debug-types"

Guess I should have looked at the recipe first :-) It already does this. 
I'll push the n450 patch per Saul's preference of minimal change.

--
Darren

>
>
> Thoughts?
>

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


  reply	other threads:[~2011-03-16 22:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 21:47 [PATCH A or B] Fix for bug #853 - matchbox-panel segfaults, X becomes unusable Darren Hart
2011-03-16 21:49 ` [PATCH A] n450: add optimization flags to gtk+ for n450 to avoid gcc core2 bug Darren Hart
2011-03-16 22:09   ` Darren Hart
2011-03-16 22:34     ` Darren Hart [this message]
2011-03-16 21:50 ` [PATCH B] atom-pc: work around gcc bug for core2 Darren Hart
2011-03-17  0:13 ` [PATCH A or B] Fix for bug #853 - matchbox-panel segfaults, X becomes unusable Richard Purdie
2011-03-17  0:15   ` Stewart, David C
2011-03-17  1:05     ` Darren Hart
2011-03-17  2:13   ` Yu Ke
2011-03-17  3:22     ` Darren Hart
2011-03-17 10:46     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D813AED.4030605@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox