Poky Project Discussions
 help / color / mirror / Atom feed
From: Kang Kai <Kai.Kang@windriver.com>
To: Colin Walters <walters@verbum.org>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 0/2] LSB: add nspr and nss to pass LSB library check
Date: Mon, 28 Mar 2011 10:43:48 +0800	[thread overview]
Message-ID: <4D8FF5E4.70202@windriver.com> (raw)
In-Reply-To: <AANLkTinrzPtDWUoGfVJZBmtSiSHBkM8WuJECkuJf2Q0B@mail.gmail.com>

On 2011年03月25日 20:50, Colin Walters wrote:
> On Fri, Mar 25, 2011 at 2:52 AM, Kang Kai<kai.kang@windriver.com>  wrote:
>> From: Kang Kai<kai.kang@windriver.com>
>>
>> add nss and nspr to provide libnss3.so, libssl3.so and libnspr4.so
>> to pass LSB library check.
>> Both are imported from oe, rev 6fe7cef27069415f2eba36bc640cf59013d4979b
Hi Colin,

Thanks for your check.

> I'm new to Yocto but have been around in the general purpose distro
> land for a while, and there is one thing that has always driven me
> nuts: patches without any comment.
> This may not be your fault, but:
>
> Take for example b/meta/recipes-extended/mozilla/nspr-4.8.7/unbreak-build.diff
>
> *why*?  Who wrote the patch?  What was broken?  Has the patch ever
> been sent upstream?
All the bb files and patches are from OpenEmbedded git repository:
git://git.openembedded.net/openembedded

I did not quit understand what the unbreak-build.diff to fix what was 
broken, but when I checked the new version of nspr, found the patch is 
not applied, so I keeped it.

> Personally I tend to hand-write something similar to "git
> format-patch" if I'm not actually creating a patch against upstream
> git (which I try hard to do).
>
> meta/recipes-extended/mozilla/nspr-4.8.7/30_config_64bits.dpatch
>
> is one that clearly should be upstream, it's just way saner.
> Planning to use nspr in my tree, so thought I'd take a look =)
> Otherwise looks pretty clean to me.



  reply	other threads:[~2011-03-28  2:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-25  6:52 [PATCH 0/2] LSB: add nspr and nss to pass LSB library check Kang Kai
2011-03-25  6:52 ` [PATCH 1/2] nspr: add nspr to pass LSB4.1 library test Kang Kai
2011-03-25  6:52 ` [PATCH 2/2] nss: add nss for LSB library check Kang Kai
2011-03-25 12:50 ` [PATCH 0/2] LSB: add nspr and nss to pass " Colin Walters
2011-03-28  2:43   ` Kang Kai [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-04-06  8:06 Kang Kai
2011-04-08 18:39 ` Saul Wold
2011-04-11  3:13   ` Kang Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D8FF5E4.70202@windriver.com \
    --to=kai.kang@windriver.com \
    --cc=poky@yoctoproject.org \
    --cc=walters@verbum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox