Poky Project Discussions
 help / color / mirror / Atom feed
From: Gary Thomas <gary@mlbassoc.com>
To: Joshua Lock <josh@linux.intel.com>
Cc: poky@yoctoproject.org
Subject: Re: How to append inc file
Date: Sat, 02 Apr 2011 11:04:28 -0600	[thread overview]
Message-ID: <4D97571C.8090701@mlbassoc.com> (raw)
In-Reply-To: <1301763560.2398.14.camel@scimitar>

On 04/02/2011 10:59 AM, Joshua Lock wrote:
> On Sat, 2011-04-02 at 21:36 +0800, Yu Ke wrote:
>> on 2011-4-2 20:57, Gary Thomas wrote:
>>> On 04/02/2011 06:52 AM, Yu Ke wrote:
>>>> Hi,
>>>>
>>>> bbappend file can be used to append content to bb file, and it is very
>>>> useful in BSP meta data. Today I just find the *.inc file is also need
>>>> to be appended, so I wonder if there
>>>> is similar incappend file that can append content to inc file?
>>>>
>>>> I meet this requirement when trying to fix bug 896
>>>> (http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make
>>>> poky-image-clutter build pass in n450, the clutter.inc need to be
>>>> appended to change the COMPATIBLE_MACHINE.
>>>
>>> Why can't you just put the change in the .bbappend file (since it's
>>> already recipe/target specific)?
>>>
>>
>> currently there is clutter 1.4 and clutter 1.6 which both use the
>> clutter.inc. and yes, It is also fine to use duplicate bbappend to
>> append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can
>> be appended, then it will reduce the duplicate code. Also inc file
>> append has another benefit, when clutter 1.8 is out in the future, the
>> BSP append code don't need any change.
>
> IIRC the common way to handle this now is to have shared code across
> versions in clutter.inc then have inc files for the major releases that
> require them (clutter-1.4.inc, clutter-1.6.inc, etc) and then have the
> version inc file include the core inc file.
> The recipes would then include the appropriate inc file for the major
> version (1.6, etc) which they build.

How does that solve the problem that the .inc file needs to have BSP
specific changes (which I find pretty abhorrent BTW)

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------


  reply	other threads:[~2011-04-02 17:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-02 12:52 How to append inc file Yu Ke
2011-04-02 12:57 ` Gary Thomas
2011-04-02 13:36   ` Yu Ke
2011-04-02 14:02     ` Gary Thomas
2011-04-02 16:59     ` Joshua Lock
2011-04-02 17:04       ` Gary Thomas [this message]
2011-04-04 16:06         ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D97571C.8090701@mlbassoc.com \
    --to=gary@mlbassoc.com \
    --cc=josh@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox