Poky Project Discussions
 help / color / mirror / Atom feed
From: Saul Wold <saul.wold@intel.com>
To: "Garman, Scott A" <scott.a.garman@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/2] cdrtools: recipe and patch cleanup
Date: Mon, 25 Apr 2011 17:37:56 -0700	[thread overview]
Message-ID: <4DB613E4.8080306@intel.com> (raw)
In-Reply-To: <4DB610D3.4020607@intel.com>

On 04/25/2011 05:24 PM, Garman, Scott A wrote:
> On 04/25/2011 05:22 PM, Wold, Saul wrote:
>> On 04/25/2011 01:08 PM, Scott Garman wrote:
>>> From: Scott Garman<scott.a.garman@intel.com>
>>>
>>> * Recipe cleanup, added missing metadata fields and fixed
>>>      whitespace issues
>>> * Added Upstream-Status to patches
>>> * Confirmed that CVE-2003-0655 does not apply to this recipe
>>>      as rscsi is not packaged
>>>
>> Scott,
>>
>> You need to add SRC_URI to this recipe.
>
> The recipe has SRC_URI. Was that a typo?
>
Yeah, the typo was SRC_URI Checksums!  They are missing from this recipe.

Sau!

> Scott
>
>
>>
>> Thanks
>>
>> Sau!
>>
>>
>>> Signed-off-by: Scott Garman<scott.a.garman@intel.com>
>>> ---
>>>     .../cdrtools-native/glibc-conflict-rename.patch    |    8 +++++++
>>>     .../cdrtools/cdrtools-native/no_usr_src.patch      |    7 ++++++
>>>     .../cdrtools/cdrtools-native_2.01.bb               |   21 ++++++++++---------
>>>     3 files changed, 26 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch b/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch
>>> index 0b9b892..2fd5696 100644
>>> --- a/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch
>>> +++ b/meta/recipes-devtools/cdrtools/cdrtools-native/glibc-conflict-rename.patch
>>> @@ -1,3 +1,11 @@
>>> +This patch fixes collisions between locally defined functions
>>> +and glibc's fexecve() and getline() functions.
>>> +
>>> +Upstream-Status: Inappropriate [Other]
>>> +Upstream no longer maintains a GPL version of this utility.
>>> +
>>> +Signed-off-by: Scott Garman<scott.a.garman@intel.com>
>>> +
>>>     Index: cdrtools-2.01/include/schily.h
>>>     ===================================================================
>>>     --- cdrtools-2.01.orig/include/schily.h	2009-06-18 11:30:45.000000000 +0100
>>> diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch b/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch
>>> index 0318d31..82e57d1 100644
>>> --- a/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch
>>> +++ b/meta/recipes-devtools/cdrtools/cdrtools-native/no_usr_src.patch
>>> @@ -1,3 +1,10 @@
>>> +Remove hard-coded references to /usr/src/linux/include to avoid
>>> +host contamination.
>>> +
>>> +Upstream-Status: [Other (build-system specific)]
>>> +
>>> +Signed-off-by: Scott Garman<scott.a.garman@intel.com>
>>> +
>>>     Index: cdrtools-2.01/DEFAULTS/Defaults.gnu
>>>     ===================================================================
>>>     --- cdrtools-2.01.orig/DEFAULTS/Defaults.gnu	2008-09-22 12:42:12.000000000 +0100
>>> diff --git a/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb b/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb
>>> index 769e5e2..edebf57 100644
>>> --- a/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb
>>> +++ b/meta/recipes-devtools/cdrtools/cdrtools-native_2.01.bb
>>> @@ -1,21 +1,22 @@
>>>     # cdrtools-native OE build file
>>>     # Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
>>>     # Released under the MIT license (see packages/COPYING)
>>> -
>>> -LICENSE="GPL"
>>> -DESCRIPTION="A set of tools for CD recording, including cdrecord"
>>> -HOMEPAGE="http://cdrecord.berlios.de/old/private/cdrecord.html"
>>> -PR = "r2"
>>> -
>>> +SUMMARY = "A set of tools for CD recording, including cdrecord"
>>> +DESCRIPTION = "A set of tools for CD recording, including cdrecord"
>>> +HOMEPAGE = "http://cdrecord.berlios.de/private/cdrecord.html"
>>> +SECTION = "console/utils"
>>> +PRIORITY = "optional"
>>> +LICENSE = "GPLv2"
>>>     LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>> +PR = "r2"
>>>
>>> -SRC_URI="ftp://ftp.berlios.de/pub/cdrecord/cdrtools-${PV}.tar.bz2 \
>>> -         file://no_usr_src.patch;patch=1 \
>>> -         file://glibc-conflict-rename.patch;patch=1"
>>> +SRC_URI = "ftp://ftp.berlios.de/pub/cdrecord/cdrtools-${PV}.tar.bz2 \
>>> +           file://no_usr_src.patch \
>>> +           file://glibc-conflict-rename.patch"
>>>
>>>     inherit native
>>>
>>> -STAGE_TEMP="${WORKDIR}/image-temp"
>>> +STAGE_TEMP = "${WORKDIR}/image-temp"
>>>
>>>     do_install() {
>>>     	install -d ${STAGE_TEMP}
>>
>
>



  reply	other threads:[~2011-04-26  0:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 20:08 [PATCH 0/2] cdrtools recipe cleanup Scott Garman
2011-04-25 20:08 ` [PATCH 1/2] cdrtools: recipe and patch cleanup Scott Garman
2011-04-26  0:22   ` Saul Wold
2011-04-26  0:24     ` Scott Garman
2011-04-26  0:37       ` Saul Wold [this message]
2011-04-25 20:08 ` [PATCH 2/2] distro_tracking_fields.inc: add cdrtools recipe Scott Garman
2011-05-06 22:38 ` [PATCH 0/2] cdrtools recipe cleanup Saul Wold
  -- strict thread matches above, loose matches on Subject: below --
2011-04-26 18:27 [PATCH 0/2] cdrtools recipe cleanup v2 Scott Garman
2011-04-26 18:27 ` [PATCH 1/2] cdrtools: recipe and patch cleanup Scott Garman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB613E4.8080306@intel.com \
    --to=saul.wold@intel.com \
    --cc=poky@yoctoproject.org \
    --cc=scott.a.garman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox