From: Saul Wold <saul.wold@intel.com>
To: "Xu, Jiajun" <jiajun.xu@intel.com>
Cc: "poky@yoctoproject.org" <poky@yoctoproject.org>
Subject: Re: [PATCH 1/1] qemuimagetest: Enable toolchain automation tests in qemuimagetest
Date: Fri, 29 Apr 2011 23:32:47 -0700 [thread overview]
Message-ID: <4DBBAD0F.6010700@intel.com> (raw)
In-Reply-To: <D5AB6E638E5A3E4B8F4406B113A5A19A51F2C729@shsmsx501.ccr.corp.intel.com>
On 04/28/2011 11:19 PM, Xu, Jiajun wrote:
>>> diff --git a/meta/classes/populate_sdk.bbclass
>>> b/meta/classes/populate_sdk.bbclass
>>> index 413eb52..70670ba 100644
>>> --- a/meta/classes/populate_sdk.bbclass
>>> +++ b/meta/classes/populate_sdk.bbclass
>>> @@ -1,6 +1,9 @@
>>> inherit meta toolchain-scripts
>>> inherit populate_sdk_${IMAGE_PKGTYPE}
>>> +IMAGETEST ?= "dummy"
>>> +inherit imagetest-${IMAGETEST}
>>> +
>> Why does this need to be added here?
>>
>> I understand that when IMAGETEST is set to qemu in the local.conf file
>> that it will be pulled in, but why to populate_sdk?
>>
>
> Hi Saul,
> Do you mean IMAGETEST should not be inherited in populate_sdk? Do you think it OK to inherit IMAGETEST in meta-toolchain.bb?
>
Jiajun,
No, I am trying to understand where the connection of having the inherit
here at all? I don't see where the imagetest is used, maybe I am not
seeing the whole picture currectly.
Sau!
> diff --git a/meta/recipes-core/meta/meta-toolchain.bb b/meta/recipes-core/meta/meta-toolchain.bb
> index 94c8a91..ab98bf9 100644
> --- a/meta/recipes-core/meta/meta-toolchain.bb
> +++ b/meta/recipes-core/meta/meta-toolchain.bb
> @@ -6,6 +6,7 @@ PR = "r4"
> LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>
> -inherit populate_sdk
> +IMAGETEST ?= "dummy"
> +inherit populate_sdk imagetest-${IMAGETEST}
>
>
>> Sau!
>
> Best Regards,
> Jiajun
>
>
>
next prev parent reply other threads:[~2011-04-30 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 15:32 [PATCH 0/1] qemuimagetest: Enable toolchain automation tests in qemuimagetest Jiajun Xu
2011-04-28 15:32 ` [PATCH 1/1] " Jiajun Xu
2011-04-29 5:10 ` Saul Wold
2011-04-29 6:19 ` Xu, Jiajun
2011-04-30 6:32 ` Saul Wold [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-05-03 5:24 [PATCH 0/1] [Resend] " Jiajun Xu
2011-05-03 5:24 ` [PATCH 1/1] " Jiajun Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DBBAD0F.6010700@intel.com \
--to=saul.wold@intel.com \
--cc=jiajun.xu@intel.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox