From: Kevin Tian <kevin.tian@intel.com>
To: poky@pokylinux.org
Subject: [PATCH 4/5] siggen.py: fix the wrong usage on BB_TASKHASH_WHITELIST
Date: Tue, 23 Nov 2010 00:35:03 +0800 [thread overview]
Message-ID: <b9dded$h5sn3a@orsmga002.jf.intel.com> (raw)
BB_TASKHASH_WHITELIST is expected to filter out native tasks from the
dependency list for target recipe's checksum. However current code
actually implements the opposite. All native sstate packages end up
to have empty task dependency while target sstate packages still have
native tasks counted into the checksum.
Signed-off-by: Kevin Tian <kevin.tian@intel.com>
---
bitbake/lib/bb/siggen.py | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/bitbake/lib/bb/siggen.py b/bitbake/lib/bb/siggen.py
index 20f57ad..26ec5ce 100644
--- a/bitbake/lib/bb/siggen.py
+++ b/bitbake/lib/bb/siggen.py
@@ -109,11 +109,13 @@ class SignatureGeneratorBasic(SignatureGenerator):
data = dataCache.basetaskhash[k]
self.runtaskdeps[k] = []
for dep in sorted(deps):
- if self.twl and self.twl.search(dataCache.pkg_fn[fn]):
- #bb.note("Skipping %s" % dep)
- continue
+ if self.twl and not self.twl.search(dataCache.pkg_fn[fn]):
+ dep_fn = re.search("(?P<fn>.*)\..*", dep).group('fn')
+ if self.twl.search(dataCache.pkg_fn[dep_fn]):
+ #bb.note("Skipping %s" % dep)
+ continue
if dep not in self.taskhash:
- bb.fatal("%s is not in taskhash, caller isn't calling in dependency order?", dep)
+ bb.fatal("%s is not in taskhash, caller isn't calling in dependency order?", dep)
data = data + self.taskhash[dep]
self.runtaskdeps[k].append(dep)
h = hashlib.md5(data).hexdigest()
--
1.6.0.4
next reply other threads:[~2010-11-23 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 16:35 Kevin Tian [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-22 16:35 [PATCH 4/5] siggen.py: fix the wrong usage on BB_TASKHASH_WHITELIST Kevin Tian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$h5sn3a@orsmga002.jf.intel.com' \
--to=kevin.tian@intel.com \
--cc=poky@pokylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox