Poky Project Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <josh@linux.intel.com>
To: poky@yoctoproject.org
Subject: [PATCH 02/10] bitbake/crumbs: do the test for ignored messages sooner
Date: Mon, 06 Dec 2010 16:11:15 -0000	[thread overview]
Message-ID: <ccdbe1e34558100b714d0fe975dfa71b85d8df17.1291651199.git.josh@linux.intel.com> (raw)
In-Reply-To: <cover.1291651199.git.josh@linux.intel.com>

Move the test for ignored messages to the start of the message handling loop to
avoid doing work for messages which are only going to be ignored.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---
 bitbake/lib/bb/ui/crumbs/runningbuild.py |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/bitbake/lib/bb/ui/crumbs/runningbuild.py b/bitbake/lib/bb/ui/crumbs/runningbuild.py
index 6f77b83..711697c 100644
--- a/bitbake/lib/bb/ui/crumbs/runningbuild.py
+++ b/bitbake/lib/bb/ui/crumbs/runningbuild.py
@@ -68,6 +68,9 @@ class RunningBuild (gobject.GObject):
                 parent = self.tasks_to_iter[(package, task)]
 
         if isinstance(event, bb.msg.MsgBase):
+            # Ignore the "Running task i of n .."
+            if (event._message.startswith ("Running task")):
+                return # don't add these to the list
 
             # Set a pretty icon for the message based on it's type.
             if isinstance(event, bb.msg.MsgWarn):
@@ -77,10 +80,6 @@ class RunningBuild (gobject.GObject):
             else:
                 icon = None
 
-            # Ignore the "Running task i of n .." messages
-            if (event._message.startswith ("Running task")):
-                return
-
             # Add the message to the tree either at the top level if parent is
             # None otherwise as a descendent of a task.
             self.model.append (parent,
-- 
1.7.3.2



  parent reply	other threads:[~2010-12-06 16:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 15:59 [PATCH 00/10] BitBake GUI fixes Joshua Lock
2010-11-25 15:15 ` [PATCH 05/10] bitbake/depexp: Factor ProgressBar into a separate class in crumbs/ Joshua Lock
2010-11-25 15:54 ` [PATCH 06/10] bitbake/crumbs: add optional pbar parameter to RunningBuild.handle_event() Joshua Lock
2010-11-25 15:56 ` [PATCH 07/10] bitbake/goggle: add a ProgressBar for parse progress Joshua Lock
2010-12-01 14:40 ` [PATCH 08/10] bitbake/xmlrpc: Modify xmlrpc server to work with Python 2.7 Joshua Lock
2010-12-01 16:59 ` [PATCH 09/10] bitbake/cooker: fix idle command processing in servers Joshua Lock
2010-12-06 15:34 ` [PATCH 10/10] bitbake/goggle: automatically show most recently added message Joshua Lock
2010-12-06 16:11 ` [PATCH 01/10] bitbake/crumbs: Fix crumbs UI for bitbake event class name changes Joshua Lock
2010-12-06 16:11 ` Joshua Lock [this message]
2010-12-06 16:11 ` [PATCH 03/10] bitbake/crumbs: fix the event name determination Joshua Lock
2010-12-06 16:11 ` [PATCH 04/10] bitbake/goggle: interaction tweaks Joshua Lock
2010-12-07 13:03 ` [PATCH 00/10] BitBake GUI fixes Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccdbe1e34558100b714d0fe975dfa71b85d8df17.1291651199.git.josh@linux.intel.com \
    --to=josh@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox