public inbox for powertop@lists.linux.dev
 help / color / mirror / Atom feed
From: Jaroslav Skarvada <jskarvad at redhat.com>
To: powertop@lists.01.org
Subject: [Powertop] [PATCH] Fix vertical scrolling in powertop-2.10
Date: Thu, 21 Mar 2019 12:13:00 -0400	[thread overview]
Message-ID: <718243314.14463242.1553184780440.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: 304227599.14463032.1553184675742.JavaMail.zimbra@redhat.com

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

Hi,

it seems there is an regression in powertop-2.10 causing
that the vertical scrolling is not working, e.g. you cannot
scroll in the overview tab. The attached patch should fix it

thanks & regards

Jaroslav

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: powertop-2.10-fix-vert-scrolling.patch --]
[-- Type: text/x-patch, Size: 536 bytes --]

diff --git a/src/display.cpp b/src/display.cpp
index 07227c5..7b3a7a2 100644
--- a/src/display.cpp
+++ b/src/display.cpp
@@ -244,7 +244,7 @@ void cursor_down(void)
 	w = tab_windows[tab_names[current_tab]];
 	if (w) {
 		if (w->ypad_pos < 1000) {
-			if (tab_names[current_tab] == "Tunables" || "WakeUp") {
+			if (tab_names[current_tab] == "Tunables" || tab_names[current_tab] == "WakeUp") {
 		                if ((w->cursor_pos + 7) >= LINES) { 
 					prefresh(w->win, ++w->ypad_pos, w->xpad_pos, 
 						1, 0, LINES - 3, COLS - 1);

                 reply	other threads:[~2019-03-21 16:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=718243314.14463242.1553184780440.JavaMail.zimbra@redhat.com \
    --to=powertop@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox