From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 540A8CCD19F for ; Mon, 20 Oct 2025 23:40:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vAzUP-00084r-Ta; Mon, 20 Oct 2025 19:40:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vAzUG-0007yp-Qg for qemu-arm@nongnu.org; Mon, 20 Oct 2025 19:40:25 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vAzUB-0001lx-Cr for qemu-arm@nongnu.org; Mon, 20 Oct 2025 19:40:24 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-b5515eaefceso4081108a12.2 for ; Mon, 20 Oct 2025 16:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761003617; x=1761608417; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MFSzp+5J2LrVZGlRDL/SOjklbQV/5g0TpauuYWG+0hI=; b=KmlBjsyPyVdGHKoMpWujQHGbZ5wYDm/TJVbaM5jM2rfpnls52+5CaId4G9qAzyuArx 9KACrIwoa+Bi3+AdVBUKg10+nXjj2G1QQ7znQ/ZwtCSCsGRptpLjmnGCpPNknTasi0WB NQlDgF+N0gecWuKGYBfShxmm0fnqDmJzhUeNgp2CFv31bwQkowJBxh8FqNYrs8Q4gOf/ WiS/wXsGVx7idryditYS9jh6hlZf/NnDWnKt5b5dnKx+qZzOSl5z+OXLpXvgyEkpKEBp i8rP2fAcZBmyPHSyKeNshBqGHxzqL1wSYBOuXC/SAxom+U2UMkh5TrX5TLw+PwyCKkUZ CquQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761003617; x=1761608417; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MFSzp+5J2LrVZGlRDL/SOjklbQV/5g0TpauuYWG+0hI=; b=oQTfsgPWt+UU0l9XXfXx54AVUFRxIVdIktJFx/cA59n24xpcovljNrt2jv9nwknva8 zs+vyVejt2qCpBoAitE24w3t59LIXPpjhczQWV7hmNRWjOK/yrGmVZZWxloPpcJYrEHi zMAs/uEDiaSgOtdyA3fF7GhJuATm7CdOhkhYUE66GnY0ZcmSrp33hwDYA3kJjp2g9oeV cxZLz2x0wSA7l9O8UoHYExZQbx2qIX80RyZbsz+zmOHqUZHI+AYuflE+cpQq8UMD85Lt aUMtQFDl6rCrDruMBGQGqs9SyKfo0FxDh8vQlwbEI41Agtp79KLkqTPlgdngkuh33/zL Tz/Q== X-Forwarded-Encrypted: i=1; AJvYcCUtR+wKuUZ510+Kzzng7GP388TZYC3dT/OVEZS2s5WguCreTRZPZ33aZzAhrAKxrHY6jyvVhoh+Eg==@nongnu.org X-Gm-Message-State: AOJu0YxiDvPHNqorbxR0AgWAWfSHmQjosMCpbKmmFAhOPrO8o8qRIOeJ 37bgpUogbk4q8P+0CW0UR3CA72sZ81q09CDjd/XkaKWoqdNb4MhCg3exZKS7S/PbgcU= X-Gm-Gg: ASbGnctxuENBPpQXnHqREu7qGtSmDvBVW45JgT8pEVPy4jKdY6Y+z/FrTZoC8hgdcmL xBeUjkn8jjJfY+gvbl1Ws0caAU6NrbBHtob+SRvnwmpJAsf9dYXyIQqnKeCWCzrkQD+b+UWENDK H3o/cQ9Tx8jEQleiEiuC3JAKDKS7awOFt2ZXzBqioHy4il8YwmsgMph3H/NM60PemI/kFu9pYVJ d+cqAWdLsk5wIcnLZFFNlxPK+5xwyYVfF18UeQooEY1xBjjWwWydJIylVd/GCnrVF6dI4YjC8DK FMkDgRfaJrm6Y3xYaVBG8aVPw05N1Z3B7a1jULXpZplzu56RM55n+oq41bDYilUGwxcRzDsjGJ/ eUDEOXOlmFVgyv7cj9ObL3vMl2VSVSEoFKt08ro6qKOt3EytAqfxkZbz27Mf6aQb5w3iTNMmp7v MkxiGa9m66g29cURXwXq82eCJF X-Google-Smtp-Source: AGHT+IHPy2QmJvXcffWfWRAaTfx/yuhaDLAYB0GCq3xI8Fm3aCTjVU5+FAUOHnzqWhxpQz04z+ppVw== X-Received: by 2002:a17:902:fc8f:b0:26b:3aab:f6b8 with SMTP id d9443c01a7336-290ccab5a83mr179303375ad.58.1761003617331; Mon, 20 Oct 2025 16:40:17 -0700 (PDT) Received: from [192.168.1.111] ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-292472197d3sm90724235ad.102.2025.10.20.16.40.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 16:40:16 -0700 (PDT) Message-ID: <051b731d-7d02-4c13-8cf2-9cec67ca8f8f@linaro.org> Date: Mon, 20 Oct 2025 16:40:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 26/30] hw/arm/virt-acpi-build: Include missing 'cpu.h' header Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Zhao Liu , Luc Michel , Anton Johansson , qemu-arm@nongnu.org, Peter Maydell , Shannon Zhao , "Michael S. Tsirkin" , Igor Mammedov , Ani Sinha References: <20251020220941.65269-1-philmd@linaro.org> <20251020222010.68708-2-philmd@linaro.org> From: Pierrick Bouvier In-Reply-To: <20251020222010.68708-2-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On 2025-10-20 15:20, Philippe Mathieu-Daudé wrote: > "cpu.h" is indirectly pulled in by another header. Include > it explicitly in order to avoid when changing default CPPFLAGS path: > > hw/arm/virt-acpi-build.c:903:34: error: call to undeclared function 'arm_feature'; > 903 | uint32_t pmu_interrupt = arm_feature(&armcpu->env, ARM_FEATURE_PMU) ? > | ^ > hw/arm/virt-acpi-build.c:903:53: error: incomplete definition of type 'ARMCPU' (aka 'struct ArchCPU') > 903 | uint32_t pmu_interrupt = arm_feature(&armcpu->env, ARM_FEATURE_PMU) ? > | ~~~~~~^ > include/qemu/typedefs.h:30:16: note: forward declaration of 'struct ArchCPU' > 30 | typedef struct ArchCPU ArchCPU; > | ^ > hw/arm/virt-acpi-build.c:903:60: error: use of undeclared identifier 'ARM_FEATURE_PMU' > 903 | uint32_t pmu_interrupt = arm_feature(&armcpu->env, ARM_FEATURE_PMU) ? > | ^ > hw/arm/virt-acpi-build.c:993:10: error: use of undeclared identifier 'QEMU_PSCI_CONDUIT_DISABLED' > 993 | case QEMU_PSCI_CONDUIT_DISABLED: > | ^ > hw/arm/virt-acpi-build.c:996:10: error: use of undeclared identifier 'QEMU_PSCI_CONDUIT_HVC' > 996 | case QEMU_PSCI_CONDUIT_HVC: > | ^ > hw/arm/virt-acpi-build.c:1000:10: error: use of undeclared identifier 'QEMU_PSCI_CONDUIT_SMC' > 1000 | case QEMU_PSCI_CONDUIT_SMC: > | ^ > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/virt-acpi-build.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Pierrick Bouvier