From: Richard Henderson <rth@twiddle.net>
To: vijay.kilari@gmail.com, qemu-arm@nongnu.org,
peter.maydell@linaro.org, pbonzini@redhat.com
Cc: Prasun.Kapoor@cavium.com, p.fedin@samsung.com,
qemu-devel@nongnu.org, Vijaya Kumar K <Vijaya.Kumar@cavium.com>
Subject: Re: [Qemu-arm] [RFC PATCH v2 2/2] utils: Add prefetch for Thunderx platform
Date: Tue, 16 Aug 2016 11:02:52 -0700 [thread overview]
Message-ID: <0f3abe4d-9640-2cc4-41db-7d5e5924e63d@twiddle.net> (raw)
In-Reply-To: <1471348968-4614-3-git-send-email-vijay.kilari@gmail.com>
On 08/16/2016 05:02 AM, vijay.kilari@gmail.com wrote:
> +static inline void prefetch_vector_loop(const VECTYPE *p, int index)
> +{
> +#if defined(__aarch64__)
> + if (is_thunderx_pass2_cpu()) {
> + /* Prefetch 4 cache lines ahead from index */
> + VEC_PREFETCH(p, index + (BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR * 4));
> + }
> +#endif
> +}
Oh come now. This is even worse than before. A function call protecting a
mere prefetch within the main body of an inner loop?
Did you not understand what I was asking for?
r~
next prev parent reply other threads:[~2016-08-16 18:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 12:02 [Qemu-arm] [RFC PATCH v2 0/2] Live migration optimization for Thunderx platform vijay.kilari
2016-08-16 12:02 ` [Qemu-devel] [RFC PATCH v2 1/2] utils: Add helper to read arm MIDR_EL1 register vijay.kilari
2016-08-17 13:39 ` [Qemu-arm] " Paolo Bonzini
2016-08-18 7:56 ` [Qemu-devel] " Vijay Kilari
2016-08-18 8:50 ` [Qemu-arm] " Paolo Bonzini
2016-08-18 9:01 ` Vijay Kilari
2016-08-18 9:39 ` Paolo Bonzini
2016-08-18 14:04 ` [Qemu-devel] " Richard Henderson
2016-08-18 14:14 ` [Qemu-arm] " Peter Maydell
2016-08-18 14:46 ` [Qemu-devel] " Richard Henderson
2016-08-18 14:56 ` [Qemu-arm] " Peter Maydell
2016-08-19 9:05 ` Vijay Kilari
2016-08-19 14:57 ` Richard Henderson
2016-08-16 12:02 ` [Qemu-arm] [RFC PATCH v2 2/2] utils: Add prefetch for Thunderx platform vijay.kilari
2016-08-16 18:02 ` Richard Henderson [this message]
2016-08-16 23:45 ` Vijay Kilari
2016-08-17 15:34 ` [Qemu-devel] " Richard Henderson
2016-08-16 16:02 ` [Qemu-arm] [Qemu-devel] [RFC PATCH v2 0/2] Live migration optimization " no-reply
2016-08-17 13:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f3abe4d-9640-2cc4-41db-7d5e5924e63d@twiddle.net \
--to=rth@twiddle.net \
--cc=Prasun.Kapoor@cavium.com \
--cc=Vijaya.Kumar@cavium.com \
--cc=p.fedin@samsung.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vijay.kilari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).